What happens with these test cases
0.0.0.0:0
:0
127.0.0.1:
www.google.com:
On 1 Jan 2013 10:27, <mt4swm@googlemail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: mikioh.mikioh@gmail.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: SplitHostPort: adjust error message for missing port in IPv6
> addresses
>
> An hostport of "[::1]" now results in the same error message
> "missing port in address" as the hostport value "127.0.0.1",
> so SplitHostPort won't complain about "too many colons
> in address" anymore for an IPv6 address missing a port.
>
> Added tests checking the error values.
>
> Fixes issue 4526.
>
> Please review this at
https://codereview.appspot.**com/7038045/<https://codereview.appspot.com/7038...
>
> Affected files:
> M src/pkg/net/ip_test.go
> M src/pkg/net/ipsock.go
>
>
> Index: src/pkg/net/ip_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/ip_test.go
> +++ b/src/pkg/net/ip_test.go
> @@ -271,12 +271,32 @@
> {"google.com", "https%foo", "google.com:https%foo"}, // Go 1.0
> behavior
> }
>
> +var splitfailuretests = []struct {
> + HostPort string
> + Err string
> +}{
> + {"www.google.com", "missing port in address"},
> + {"127.0.0.1", "missing port in address"},
> + {"[::1]", "missing port in address"},
> + {"::1", "too many colons in address"},
> +}
> +
> func TestSplitHostPort(t *testing.T) {
> for _, tt := range splitjointests {
> if host, port, err := SplitHostPort(tt.Join); host !=
> tt.Host || port != tt.Port || err != nil {
> t.Errorf("SplitHostPort(%q) = %q, %q, %v; want %q,
> %q, nil", tt.Join, host, port, err, tt.Host, tt.Port)
> }
> }
> + for _, tt := range splitfailuretests {
> + if _, _, err := SplitHostPort(tt.HostPort); err == nil {
> + t.Errorf("SplitHostPort(%q) should have failed",
> tt.HostPort)
> + } else {
> + e := err.(*AddrError)
> + if e.Err != tt.Err {
> + t.Errorf("SplitHostPort(%q) = _, _, %q;
> want %q", tt.HostPort, e.Err, tt.Err)
> + }
> + }
> + }
> }
>
> func TestJoinHostPort(t *testing.T) {
> Index: src/pkg/net/ipsock.go
> ==============================**==============================**=======
> --- a/src/pkg/net/ipsock.go
> +++ b/src/pkg/net/ipsock.go
> @@ -85,9 +85,12 @@
> }
> host, port = hostport[:i], hostport[i+1:]
> // Can put brackets around host ...
> - if len(host) > 0 && host[0] == '[' && host[len(host)-1] == ']' {
> + switch {
> + case insideBrackets(host):
> host = host[1 : len(host)-1]
> - } else {
> + case insideBrackets(hostport):
> + err = &AddrError{"missing port in address", hostport}
> + default:
> // ... but if there are no brackets, no colons.
> if byteIndex(host, ':') >= 0 {
> err = &AddrError{"too many colons in address",
> hostport}
> @@ -97,6 +100,10 @@
> return
> }
>
> +func insideBrackets(s string) bool {
> + return len(s) > 0 && s[0] == '[' && s[len(s)-1] == ']'
> +}
> +
> // JoinHostPort combines host and port into a network address
> // of the form "host:port" or, if host contains a colon, "[host]:port".
> func JoinHostPort(host, port string) string {
>
>
>