Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 70200056: code review 70200056: runtime: Generic hash and equal for types with nil alg-...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by crc
Modified:
11 years, 10 months ago
Reviewers:
rsc, golang-codereviews
CC:
iant, khr
Visibility:
Public.
runtime: Generic hash and equal for types with nil alg->hash|equal. Used when hashing or comparing interfaces with dynamic struct or array types. Fixes issue 7447.

Patch Set 1 #

Patch Set 2 : diff -r 13f8dc6e750f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 4cd83f2e218e https://code.google.com/p/go/ #

Created: 11 years, 10 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -6 lines) Patch
M src/pkg/runtime/export_test.go View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/iface.goc View 1 5 chunks +117 lines, -6 lines 0 comments Download
M src/pkg/runtime/iface_test.go View 1 2 chunks +147 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/type.h View 1 1 chunk +23 lines, -0 lines 0 comments Download
Total messages: 2
|
crc
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, khr@golang.org, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/
11 years, 10 months ago (2014年03月05日 06:02:57 UTC) #1
Hello golang-codereviews@googlegroups.com (cc: iant@golang.org, khr@golang.org,
rsc@golang.org),
I'd like you to review this change to
https://code.google.com/p/go/ 
Sign in to reply to this message.
rsc
R=close Sorry, but we've entered the feature freeze period for Go 1.3. This may be ...
11 years, 10 months ago (2014年03月05日 20:08:33 UTC) #2
R=close
Sorry, but we've entered the feature freeze period for Go 1.3. This may be a
fine change, but we need to focus on making what's already here stable. Please
ping this once we've started on Go 1.4 (probably June 1).
Thanks.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /