Issue 6944056: openpgp: remove TeeReader from packet.Read

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(15)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6944056: openpgp: remove TeeReader from packet.Read

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by cmars

Modified:
13 years ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

openpgp: remove TeeReader from packet.Read This is a followup to issue 6927044. I *really* don't want to break streaming for large encrypted data packets. Removing the automatic re-parsing. OpaqueReader can be used for recovering useful information from mangled/unsupported packets.

Patch Set 1 #

Patch Set 2 : openpgp: remove TeeReader from packet.Read #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -17 lines)			Patch
M	openpgp/packet/opaque.go	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
A	openpgp/packet/opaque_test.go	View	1	1 chunk	+75 lines, -0 lines	1 comment	Download
M	openpgp/packet/packet.go	View	1	2 chunks	+2 lines, -16 lines	0 comments	Download

Total messages: 2

cmars

PTAL

13 years ago (2012年12月16日 19:17:48 UTC) #1

PTAL

agl1

*** Submitted as https://code.google.com/p/go/source/detail?r=17ced002e171&repo=crypto *** openpgp: remove TeeReader from packet.Read This is a followup to ...

13 years ago (2012年12月18日 22:57:27 UTC) #2

*** Submitted as
https://code.google.com/p/go/source/detail?r=17ced002e171&repo=crypto ***
openpgp: remove TeeReader from packet.Read
This is a followup to issue 6927044. I *really* don't want to
break streaming for large encrypted data packets.
Removing the automatic re-parsing. OpaqueReader can be
used for recovering useful information from mangled/unsupported packets.
R=agl
CC=golang-dev
https://codereview.appspot.com/6944056
Committer: Adam Langley <agl@golang.org>
https://codereview.appspot.com/6944056/diff/2001/openpgp/packet/opaque_test.go
File openpgp/packet/opaque_test.go (right):
https://codereview.appspot.com/6944056/diff/2001/openpgp/packet/opaque_test.g...
openpgp/packet/opaque_test.go:39: pktNum := 0
Some of the variable names are a little compact. Will expand before submitting.