|
|
|
archive/zip: Fix bounds check panic for ZIP files with a truncated extra header.
Patch Set 1 #Patch Set 2 : diff -r c33545ae0ec0 https://code.google.com/p/go #Patch Set 3 : diff -r ad0d92901061 https://code.google.com/p/go #
Total comments: 4
Patch Set 4 : diff -r ad0d92901061 https://code.google.com/p/go #
Total messages: 8
|
davemc
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
|
13 years, 2 months ago (2012年11月07日 02:35:51 UTC) #1 | ||||||||||||||||||||||||
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
R=adg (assigned by dsymonds)
On 2012年11月07日 03:20:02, gobot wrote: > R=adg (assigned by dsymonds) Very nice, thank you for fixing this.
https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test.go File src/pkg/archive/zip/zip_test.go (right): https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test... src/pkg/archive/zip/zip_test.go:193: if _, err = NewReader(bytes.NewReader(b), int64(len(b))); err == nil { err != ErrFormat https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test... src/pkg/archive/zip/zip_test.go:194: t.Fatal("expected ErrFormat") t.Fatalf("got %v, expected ErrFormat", err)
Hello adg@golang.org, dave@cheney.net (cc: gobot@golang.org, golang-dev@googlegroups.com), Please take another look.
https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test.go File src/pkg/archive/zip/zip_test.go (right): https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test... src/pkg/archive/zip/zip_test.go:193: if _, err = NewReader(bytes.NewReader(b), int64(len(b))); err == nil { On 2012年11月07日 09:30:26, adg wrote: > err != ErrFormat Done. https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test... src/pkg/archive/zip/zip_test.go:194: t.Fatal("expected ErrFormat") On 2012年11月07日 09:30:26, adg wrote: > t.Fatalf("got %v, expected ErrFormat", err) Done.
LGTM
*** Submitted as http://code.google.com/p/go/source/detail?r=f5c69f87ef34 *** archive/zip: Fix bounds check panic for ZIP files with a truncated extra header. R=adg, dave CC=gobot, golang-dev http://codereview.appspot.com/6811080 Committer: Andrew Gerrand <adg@golang.org>