|
|
|
Created:
13 years, 2 months ago by dvyukov2 Modified:
12 years, 7 months ago CC:
brainman Visibility:
Public. |
runtime/race: add Windows support
Patch Set 1 #Patch Set 2 : diff -r 126c37a9e33c https://go.googlecode.com/hg/ #Patch Set 3 : diff -r 126c37a9e33c https://go.googlecode.com/hg/ #Patch Set 4 : diff -r 126c37a9e33c https://go.googlecode.com/hg/ #Patch Set 5 : diff -r 8b32d1715714 https://go.googlecode.com/hg/ #Patch Set 6 : diff -r 8b32d1715714 https://go.googlecode.com/hg/ #
Total comments: 1
Total messages: 5
|
dvyukov2
Hello golang-dev@googlegroups.com (cc: alex.brainman@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/
|
13 years, 2 months ago (2012年11月07日 09:56:33 UTC) #1 | |||||||||||||||||||||||||||||||||||||||
Hello golang-dev@googlegroups.com (cc: alex.brainman@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/
LGTM In a separate CL could you please add a README to src/pkg/runtime/race that explains briefly how to generate the .syso files? I don't want to ship binaries without explaining where they came from. Thanks. https://codereview.appspot.com/6810080/diff/10001/src/run.bat File src/run.bat (right): https://codereview.appspot.com/6810080/diff/10001/src/run.bat#newcode56 src/run.bat:56: echo '# Testing race detector.' Drop the quotes. There's no quoting in this "shell".
On 2012年11月07日 14:46:45, rsc wrote: > LGTM > > In a separate CL could you please add a README to src/pkg/runtime/race that > explains briefly how to generate the .syso files? I don't want to ship binaries > without explaining where they came from. Sure. > > Thanks. > > https://codereview.appspot.com/6810080/diff/10001/src/run.bat > File src/run.bat (right): > > https://codereview.appspot.com/6810080/diff/10001/src/run.bat#newcode56 > src/run.bat:56: echo '# Testing race detector.' > Drop the quotes. There's no quoting in this "shell". I've copied it to another CL: https://codereview.appspot.com/6827060 because dvyukov@gmail.com is not in CONTRIBUTORS.
On 2012年11月07日 14:46:45, rsc wrote: > LGTM > > In a separate CL could you please add a README to src/pkg/runtime/race that > explains briefly how to generate the .syso files? I don't want to ship binaries > without explaining where they came from. Sure. > > Thanks. > > https://codereview.appspot.com/6810080/diff/10001/src/run.bat > File src/run.bat (right): > > https://codereview.appspot.com/6810080/diff/10001/src/run.bat#newcode56 > src/run.bat:56: echo '# Testing race detector.' > Drop the quotes. There's no quoting in this "shell". I've copied it to another CL: https://codereview.appspot.com/6827060 because dvyukov@gmail.com is not in CONTRIBUTORS.