|
|
|
go.crypto/bcrypt: add Cost function
Extracts the cost used to generate a bcrypt hash from the hash itself.
Patch Set 1 #Patch Set 2 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #Patch Set 3 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #Patch Set 4 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #
Total comments: 1
Patch Set 5 : diff -r ffee30e1c207 https://code.google.com/p/go.crypto #Total messages: 6
|
jmhodges
Hello agl@chromium.org (cc: dchest@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
|
13 years, 2 months ago (2012年10月30日 07:05:30 UTC) #1 |
Hello agl@chromium.org (cc: dchest@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
https://codereview.appspot.com/6810051/diff/1002/bcrypt/bcrypt.go File bcrypt/bcrypt.go (right): https://codereview.appspot.com/6810051/diff/1002/bcrypt/bcrypt.go#newcode117 bcrypt/bcrypt.go:117: // Cost returns the cost that the hashed password was made with. This is I don't think this comment is quite right. Why is Cost useful when a user's hash needs to be made more difficult? (I know why, but not by reading the comment.) // Cost returns the hashing cost used to create the given hashed password. When, in the future, the hashing cost of a password system needs to be increased in order to adjust for greater computational power, this function allows one to establish which passwords need to be updated.
LGTM with agl's suggestion.
Hello agl@chromium.org, agl@golang.org, dchest@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
Gentlest of pings.
*** Submitted as http://code.google.com/p/go/source/detail?r=7fd55a277056&repo=crypto *** go.crypto/bcrypt: add Cost function Extracts the cost used to generate a bcrypt hash from the hash itself. R=agl, agl, dchest CC=golang-dev http://codereview.appspot.com/6810051 Committer: Adam Langley <agl@golang.org>