Keyboard Shortcuts
File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(204)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6781053: code review 6781053: go.net/spdy: disallow stream id 0

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by jmhodges
Modified:
13 years, 2 months ago
Reviewers:
mikio , bradfitz
CC:
mikio, bradfitz, adg, golang-dev
Visibility:
Public.
go.net/spdy: disallow stream id 0 Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.

Patch Set 1 #

Patch Set 2 : diff -r af69687727e7 https://code.google.com/p/go.net #

Patch Set 3 : diff -r af69687727e7 https://code.google.com/p/go.net #

Patch Set 4 : code review 6781053: net/spdy: disallow stream id 0 #

Patch Set 5 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Patch Set 6 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Total comments: 1

Patch Set 7 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Patch Set 8 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Patch Set 9 : diff -r 3fefc1da6aa9 https://code.google.com/p/go.net #

Created: 13 years, 2 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M spdy/read.go View 1 2 3 4 6 chunks +18 lines, -0 lines 0 comments Download
M spdy/spdy_test.go View 1 2 3 4 5 6 7 9 chunks +70 lines, -1 line 0 comments Download
M spdy/types.go View 1 4 1 chunk +1 line, -0 lines 0 comments Download
M spdy/write.go View 1 4 5 chunks +18 lines, -0 lines 0 comments Download
Total messages: 9
|
jmhodges
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
13 years, 2 months ago (2012年10月27日 00:12:38 UTC) #1 
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go.net
Sign in to reply to this message.
jmhodges
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012年10月29日 17:08:46 UTC) #2 
Hello mikioh.mikioh@gmail.com (cc: adg@golang.org, golang-dev@googlegroups.com),
Please take another look.
Sign in to reply to this message.
jmhodges
Fixed up the conflict that arose around importing encoding/base64 after https://codereview.appspot.com/6786055/ shipped.
13 years, 2 months ago (2012年10月29日 17:10:38 UTC) #3 
Fixed up the conflict that arose around importing encoding/base64 after
https://codereview.appspot.com/6786055/ shipped.
Sign in to reply to this message.
bradfitz
LGTM https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go File spdy/spdy_test.go (right): https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go#newcode584 spdy/spdy_test.go:584: reader, err := NewFramer(buf, buf) reading and writing ...
13 years, 2 months ago (2012年10月29日 17:18:40 UTC) #4 
LGTM
https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go
File spdy/spdy_test.go (right):
https://codereview.appspot.com/6781053/diff/11001/spdy/spdy_test.go#newcode584
spdy/spdy_test.go:584: reader, err := NewFramer(buf, buf)
reading and writing to the same place? seems sketchy.
this seems more clear: NewFramer(buf, bytes.NewReader(b))
or even:
NewFramer(ioutil.Discard, bytes.NewReader(b))
.. since you don't seem to use buf later anyway?
Sign in to reply to this message.
jmhodges
Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org, golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012年10月29日 17:31:49 UTC) #5
Sign in to reply to this message.
jmhodges
> > NewFramer(ioutil.Discard, bytes.NewReader(b)) > > .. since you don't seem to use buf later ...
13 years, 2 months ago (2012年10月29日 17:32:09 UTC) #6 
>
> NewFramer(ioutil.Discard, bytes.NewReader(b))
> 
> .. since you don't seem to use buf later anyway?
This is much better. Done.
Sign in to reply to this message.
mikio
LGTM please change the CL description to go.net/spdy, thx.
13 years, 2 months ago (2012年10月30日 06:18:16 UTC) #7 
LGTM
please change the CL description to go.net/spdy, thx.
Sign in to reply to this message.
jmhodges
Hello mikioh.mikioh@gmail.com, bradfitz@golang.org (cc: adg@golang.org, golang-dev@googlegroups.com), Please take another look.
13 years, 2 months ago (2012年10月30日 06:29:12 UTC) #8
Sign in to reply to this message.
mikio
*** Submitted as http://code.google.com/p/go/source/detail?r=c6c20fbea877&repo=net *** go.net/spdy: disallow stream id 0 Per 2.3.2 of draft-mbelshe-httpbis-spdy-00. R=mikioh.mikioh, ...
13 years, 2 months ago (2012年10月30日 07:13:03 UTC) #9 
*** Submitted as
http://code.google.com/p/go/source/detail?r=c6c20fbea877&repo=net ***
go.net/spdy: disallow stream id 0
Per 2.3.2 of draft-mbelshe-httpbis-spdy-00.
R=mikioh.mikioh, bradfitz
CC=adg, golang-dev
http://codereview.appspot.com/6781053
Committer: Mikio Hara <mikioh.mikioh@gmail.com>
Sign in to reply to this message.
|
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /