|
|
|
Enable TLS on websockets.
Fixed how we dynamically switch the wrapped protocol
when a secure connection is used.
The server now uses TLS both for web and websocket
connections.
The https and wss connections use the same port.
https://code.launchpad.net/~frankban/juju/enable-tls/+merge/131358
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 2
Patch Set 2 : Enable TLS on websockets. #Patch Set 3 : Enable TLS on websockets. #Patch Set 4 : Enable TLS on websockets. #
Total messages: 3
|
frankban
Please take a look.
|
13 years, 2 months ago (2012年10月25日 09:48:12 UTC) #1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Please take a look.
looks good, one minor, let me know what you think. https://codereview.appspot.com/6765051/diff/1/juju/agents/api.py File juju/agents/api.py (right): https://codereview.appspot.com/6765051/diff/1/juju/agents/api.py#newcode44 juju/agents/api.py:44: os.path.join(os.path.dirname(__file__), 'keys')) if your up for it, i'd like this to be a cli option with a fallback to included if not specified, rather then a hardcode. https://codereview.appspot.com/6765051/diff/1/juju/lib/websockets.py File juju/lib/websockets.py (right): https://codereview.appspot.com/6765051/diff/1/juju/lib/websockets.py#newcode514 juju/lib/websockets.py:514: if request.isSecure(): beautiful