Issue 67045: Tell libtool and aclocal about the `m4' sub-directory.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(102)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 67045: Tell libtool and aclocal about the `m4' sub-directory.

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by tsuna

Modified:
16 years, 8 months ago

Reviewers:
chandlerc, Zhanyong Wan

CC:
googletestframework_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
M	Makefile.am	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	configure.ac	View	1 chunk	+2 lines, -0 lines	2 comments	Download

Total messages: 2

Zhanyong Wan

I'm not qualified to review this. Chandler, can you be the reviewer? Thanks.

16 years, 8 months ago (2009年05月14日 04:38:55 UTC) #1

I'm not qualified to review this. Chandler, can you be the reviewer? Thanks.

chandlerc

http://codereview.appspot.com/67045/diff/1/3 File configure.ac (right): http://codereview.appspot.com/67045/diff/1/3#newcode19 Line 19: nit: Extraneous blank line. http://codereview.appspot.com/67045/diff/1/3#newcode20 Line 20: AC_CONFIG_MACRO_DIR([m4]) ...

16 years, 8 months ago (2009年05月14日 18:59:19 UTC) #2

http://codereview.appspot.com/67045/diff/1/3
File configure.ac (right):
http://codereview.appspot.com/67045/diff/1/3#newcode19
Line 19: 
nit: Extraneous blank line.
http://codereview.appspot.com/67045/diff/1/3#newcode20
Line 20: AC_CONFIG_MACRO_DIR([m4])
Does this introduce any dependencies on versions of Autoconf installed on a
developer's machine? I'm generally OK if it does, but we should document them in
the README.