Issue 6601060: Give integer maas constraints without decimal

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(137)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6601060: Give integer maas constraints without decimal

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by gz

Modified:
13 years, 3 months ago

Reviewers:
hazmat , mp+127987

Visibility:
Public.

Give integer maas constraints without decimal Currently generic cpu and mem constraints are cast to float inside juju, this isn't really useful for memory in MB or cpu count as used by MaaS. It also happens to upset the current code. Giving the integer form instead is reasonable. https://code.launchpad.net/~gz/juju/maas_int_constraints_1061286/+merge/127987 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/maas/maas.py	View	2 chunks	+12 lines, -7 lines	0 comments	Download
M	juju/providers/maas/tests/test_maas.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2

Please take a look.

13 years, 3 months ago (2012年10月04日 11:41:21 UTC) #1

Please take a look.