|
|
Please take a look. Thanks! --brendan
Please take a look at our other Java samples and try to follow their structure. One particular feature is the use of Maven for build/running the sample and therefore remove the need to put jars in source control. https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cl... File jcompute-java/src/com/google/cloud/api/example/JCompute.java (right): https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cl... jcompute-java/src/com/google/cloud/api/example/JCompute.java:2: * Copyright (c) 2011 Google Inc. no copyright line please (this is a change in legal requirements for opensource code at Google) https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cl... jcompute-java/src/com/google/cloud/api/example/JCompute.java:97: public static Credential authorize( We've significantly improved the OAuth 2.0 command-line experience in the Java library with version 1.11.0-beta. For an example, please take a look at the authorize() method in: http://code.google.com/p/google-api-java-client/source/browse/calendar-cmdlin...
Are there docs for using maven somewhere? Thanks --brendan On Thu, Sep 27, 2012 at 3:07 PM, <yanivi@google.com> wrote: > Please take a look at our other Java samples and try to follow their > structure. One particular feature is the use of Maven for build/running > the sample and therefore remove the need to put jars in source control. > > > https://codereview.appspot.**com/6571067/diff/1/jcompute-** > java/src/com/google/cloud/api/**example/JCompute.java<https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cloud/api/example/JCompute.java> > File jcompute-java/src/com/google/**cloud/api/example/JCompute.**java > (right): > > https://codereview.appspot.**com/6571067/diff/1/jcompute-** > java/src/com/google/cloud/api/**example/JCompute.java#newcode2<https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cloud/api/example/JCompute.java#newcode2> > jcompute-java/src/com/google/**cloud/api/example/JCompute.**java:2: * > Copyright (c) 2011 Google Inc. > no copyright line please > (this is a change in legal requirements for opensource code at Google) > > https://codereview.appspot.**com/6571067/diff/1/jcompute-** > java/src/com/google/cloud/api/**example/JCompute.java#**newcode97<https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cloud/api/example/JCompute.java#newcode97> > jcompute-java/src/com/google/**cloud/api/example/JCompute.**java:97: > public > static Credential authorize( > We've significantly improved the OAuth 2.0 command-line experience in > the Java library with version 1.11.0-beta. For an example, please take > a look at the authorize() method in: > > http://code.google.com/p/**google-api-java-client/source/** > browse/calendar-cmdline-**sample/src/main/java/com/** > google/api/services/samples/**calendar/cmdline/**CalendarSample.java?repo= > **samples<http://code.google.com/p/google-api-java-client/source/browse/calendar-cmdline-sample/src/main/java/com/google/api/services/samples/calendar/cmdline/CalendarSample.java?repo=samples> > > https://codereview.appspot.**com/6571067/<https://codereview.appspot.com/6571... >
There is some basic information available here: http://maven.apache.org/ But realistically the easiest way for you to progress is to copy an existing sample and follow the instructions.html file for actually compiling. I understand it can be a process to learn how to set up a Maven project at the beginning, but in the long term it makes it much easier to maintain. -- Yaniv On Thu, Sep 27, 2012 at 7:13 PM, Brendan Burns <bburns@google.com> wrote: > Are there docs for using maven somewhere? > > Thanks > --brendan > > > On Thu, Sep 27, 2012 at 3:07 PM, <yanivi@google.com> wrote: > >> Please take a look at our other Java samples and try to follow their >> structure. One particular feature is the use of Maven for build/running >> the sample and therefore remove the need to put jars in source control. >> >> >> https://codereview.appspot.**com/6571067/diff/1/jcompute-** >> java/src/com/google/cloud/api/**example/JCompute.java<https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cloud/api/example/JCompute.java> >> File jcompute-java/src/com/google/**cloud/api/example/JCompute.**java >> (right): >> >> https://codereview.appspot.**com/6571067/diff/1/jcompute-** >> java/src/com/google/cloud/api/**example/JCompute.java#newcode2<https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cloud/api/example/JCompute.java#newcode2> >> jcompute-java/src/com/google/**cloud/api/example/JCompute.**java:2: * >> Copyright (c) 2011 Google Inc. >> no copyright line please >> (this is a change in legal requirements for opensource code at Google) >> >> https://codereview.appspot.**com/6571067/diff/1/jcompute-** >> java/src/com/google/cloud/api/**example/JCompute.java#**newcode97<https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cloud/api/example/JCompute.java#newcode97> >> jcompute-java/src/com/google/**cloud/api/example/JCompute.**java:97: >> public >> static Credential authorize( >> We've significantly improved the OAuth 2.0 command-line experience in >> the Java library with version 1.11.0-beta. For an example, please take >> a look at the authorize() method in: >> >> http://code.google.com/p/**google-api-java-client/source/** >> browse/calendar-cmdline-**sample/src/main/java/com/** >> google/api/services/samples/**calendar/cmdline/** >> CalendarSample.java?repo=**samples<http://code.google.com/p/google-api-java-client/source/browse/calendar-cmdline-sample/src/main/java/com/google/api/services/samples/calendar/cmdline/CalendarSample.java?repo=samples> >> >> https://codereview.appspot.**com/6571067/<https://codereview.appspot.com/6571... >> > >
- I agree with Yaniv, in my experience maven is a really great way to maintain Java apps (also his point about trying to make this more consistent with the existing java samples). - Does it make sense to include all those products? (class files, jar files, etc.). It seems like the jars are external deps, which should perhaps be referenced, not copied and the class files are generated. https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cl... File jcompute-java/src/com/google/cloud/api/example/JCompute.java (right): https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cl... jcompute-java/src/com/google/cloud/api/example/JCompute.java:9: * Unless required by applicable law or agreed to in writing, software distributed under the License line wraps (global) https://codereview.appspot.com/6571067/diff/1/jcompute-java/src/com/google/cl... jcompute-java/src/com/google/cloud/api/example/JCompute.java:65: "https://www.googleapis.com/compute/v1beta12"; latest is 13 (which shows how long it took me to review this :).