|
|
|
graphics-go: fix opencv_parser xml decoding
Patch Set 1 #Patch Set 2 : diff -r 1c2e9ddd42b8 https://code.google.com/p/graphics-go #Patch Set 3 : diff -r 1c2e9ddd42b8 https://code.google.com/p/graphics-go #Total messages: 6
|
proppy
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/graphics-go
|
13 years, 4 months ago (2012年09月13日 02:45:04 UTC) #1 |
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/graphics-go
+nigeltao, crawshaw1
On 2012年09月13日 02:47:10, proppy wrote: > +nigeltao, crawshaw1 crawshaw knows the opencv stuff better than I do. I'll defer to him, but... can you give an example of an XML file that failed before and passes afterwards?
On 2012年09月13日 05:42:12, nigeltao wrote: > On 2012年09月13日 02:47:10, proppy wrote: > > +nigeltao, crawshaw1 > > crawshaw knows the opencv stuff better than I do. I'll defer to him, but... can > you give an example of an XML file that failed before and passes afterwards? https://github.com/Itseez/opencv/blob/master/data/haarcascades/haarcascade_fr... https://github.com/Itseez/opencv/blob/master/data/haarcascades/haarcascade_fr...
LGTM Thanks for the patch.
*** Submitted as http://code.google.com/p/graphics-go/source/detail?r=f843bfcd8ac4 *** graphics-go: fix opencv_parser xml decoding R=nigeltao, crawshaw CC=golang-dev http://codereview.appspot.com/6495122 Committer: Nigel Tao <nigeltao@golang.org>