|
|
|
doc css: topbar sticks to the top of large windows.
Rationale: for large screens, the convenience of not having to scroll
to the top of the page to do a search outweighs having less vertical
space.
Tested with Chrome, Firefox, Safari with various window and text sizes.
Patch Set 1 #Patch Set 2 : diff -r 272e1dd72156 https://code.google.com/p/go/ #Patch Set 3 : diff -r 272e1dd72156 https://code.google.com/p/go/ #Patch Set 4 : diff -r 272e1dd72156 https://code.google.com/p/go/ #Total messages: 6
|
skybrian1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
|
13 years, 4 months ago (2012年09月03日 02:46:59 UTC) #1 |
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
R=adg (assigned by rsc)
LGTM Nice change.
*** Submitted as http://code.google.com/p/go/source/detail?r=56c7453d488f *** doc css: topbar sticks to the top of large windows. Rationale: for large screens, the convenience of not having to scroll to the top of the page to do a search outweighs having less vertical space. Tested with Chrome, Firefox, Safari with various window and text sizes. R=adg CC=gobot, golang-dev http://codereview.appspot.com/6493071 Committer: Andrew Gerrand <adg@golang.org>
When should I expect this change to appear on golang.org? On Monday, September 10, 2012 6:38:52 PM UTC-7, Andrew Gerrand wrote: > > *** Submitted as > http://code.google.com/p/go/source/detail?r=56c7453d488f *** > > doc css: topbar sticks to the top of large windows. > Rationale: for large screens, the convenience of not having to scroll > to the top of the page to do a search outweighs having less vertical > space. > Tested with Chrome, Firefox, Safari with various window and text sizes. > > R=adg > CC=gobot, golang-dev > http://codereview.appspot.com/6493071 > > Committer: Andrew Gerrand <a...@golang.org <javascript:>> > > > http://codereview.appspot.com/6493071/ >
On Sun, Sep 30, 2012 at 9:06 PM, <bslesinsky@gmail.com> wrote: > When should I expect this change to appear on golang.org? > This change was reverted by https://codereview.appspot.com/6488121/ because it didn't handle anchor links well.