Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(228)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6492081: code review 6492081: oauth: Improve error handling. Add Oauth specific error...

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by manugarg1
Modified:
12 years, 5 months ago
Reviewers:
adg
CC:
adg, golang-dev
Visibility:
Public.
oauth: Improve error handling. Add Oauth specific error type - OAuthError.

Patch Set 1 #

Patch Set 2 : diff -r 76d44ce1c666 https://code.google.com/p/goauth2/ #

Patch Set 3 : diff -r 76d44ce1c666 https://code.google.com/p/goauth2/ #

Patch Set 4 : diff -r ee227149d571 https://code.google.com/p/goauth2/ #

Patch Set 5 : diff -r ee227149d571 https://code.google.com/p/goauth2/ #

Created: 13 years, 4 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M oauth/oauth.go View 1 2 3 4 7 chunks +18 lines, -11 lines 0 comments Download
Total messages: 4
|
manugarg1
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2/
13 years, 4 months ago (2012年09月05日 17:34:20 UTC) #1
Hello adg@golang.org (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/goauth2/ 
Sign in to reply to this message.
adg
LGTM
13 years, 4 months ago (2012年09月11日 01:29:05 UTC) #2
LGTM
Sign in to reply to this message.
adg
*** Submitted as http://code.google.com/p/goauth2/source/detail?r=69ae34b71f97 *** oauth: Improve error handling. Add Oauth specific error type - ...
13 years, 4 months ago (2012年09月11日 01:30:16 UTC) #3
*** Submitted as http://code.google.com/p/goauth2/source/detail?r=69ae34b71f97
***
oauth: Improve error handling. Add Oauth specific error type - OAuthError.
R=adg
CC=golang-dev
http://codereview.appspot.com/6492081
Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.
remyoudompheng
R=close
12 years, 5 months ago (2013年07月21日 19:58:38 UTC) #4
R=close
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /