google-http-client/src/main/java/com/google/api/client/http/UriTemplate.java - Issue 6464066: Allow escaping algorithm to be specified in GenericUrl

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

(164)

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Unified Diff: google-http-client/src/main/java/com/google/api/client/http/UriTemplate.java

Issue 6464066: Allow escaping algorithm to be specified in GenericUrl Base URL: https://google-http-java-client.googlecode.com/hg/

Patch Set: Minor fix Created 13 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: google-http-client/src/main/java/com/google/api/client/http/UriTemplate.java

===================================================================

--- a/google-http-client/src/main/java/com/google/api/client/http/UriTemplate.java

+++ b/google-http-client/src/main/java/com/google/api/client/http/UriTemplate.java

@@ -335,7 +335,7 @@

}

if (addUnusedParamsAsQueryParams) {

// Add the parameters remaining in the variableMap as query parameters.

- GenericUrl.addQueryParams(variableMap.entrySet(), pathBuf);

+ GenericUrl.addQueryParams(variableMap.entrySet(), pathBuf, new DefaultGenericUrlEscaper());

}

return pathBuf.toString();

}

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b