Issue 6459103: code review 6459103: goauth2: add -auth -token -redirect, and -ap flags

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(353)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6459103: code review 6459103: goauth2: add -auth -token -redirect, and -ap flags

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by ajstarks

Modified:
13 years, 4 months ago

Reviewers:
adg

CC:
adg, golang-dev

Visibility:
Public.

goauth2: add -auth -token -redirect, and -ap flags allowing the example to work with other OAuth2 providers Tested with Microsoft, Google, and Meetup

Patch Set 1 #

Patch Set 2 : diff -r d46e2cc11a0a https://code.google.com/p/goauth2 #

Patch Set 3 : diff -r d46e2cc11a0a https://code.google.com/p/goauth2 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
M	oauth/example/oauthreq.go	View	1	4 chunks	+16 lines, -9 lines	0 comments	Download

Total messages: 3

ajstarks

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2

13 years, 4 months ago (2012年08月18日 12:47:46 UTC) #1

Hello adg@golang.org (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/goauth2

adg

LGTM

13 years, 4 months ago (2012年08月20日 02:03:57 UTC) #2

LGTM

adg

*** Submitted as http://code.google.com/p/goauth2/source/detail?r=76d44ce1c666 *** goauth2: add -auth -token -redirect, and -ap flags allowing the ...

13 years, 4 months ago (2012年08月20日 02:04:31 UTC) #3

*** Submitted as http://code.google.com/p/goauth2/source/detail?r=76d44ce1c666
***
goauth2: add -auth -token -redirect, and -ap flags
allowing the example to work with other OAuth2 providers
Tested with Microsoft, Google, and Meetup
R=adg
CC=golang-dev
http://codereview.appspot.com/6459103
Committer: Andrew Gerrand <adg@golang.org>