Issue 6443090: Ensure charm store SSL is authenticated

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(114)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6443090: Ensure charm store SSL is authenticated

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by SpamapS

Modified:
13 years, 5 months ago

Reviewers:
mp+118422, hazmat

Visibility:
Public.

Ensure charm store SSL is authenticated Use VerifyingContextFactory to ensure charm store interaction is authenticated https://code.launchpad.net/~clint-fewbar/juju/fix-ssl-for-charm-store/+merge/118422 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/charm/repository.py	View	3 chunks	+5 lines, -2 lines	2 comments	Download
M	juju/charm/tests/test_repository.py	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	juju/control/tests/test_upgrade_charm.py	View	3 chunks	+5 lines, -2 lines	0 comments	Download

Total messages: 2

SpamapS

Please take a look.

13 years, 5 months ago (2012年08月06日 20:30:05 UTC) #1

Please take a look.

hazmat

lgtm, with these minors https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py File juju/charm/repository.py (right): https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcode130 juju/charm/repository.py:130: host = url.split('/')[2] this would ...

13 years, 5 months ago (2012年08月08日 11:11:55 UTC) #2

lgtm, with these minors
https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py
File juju/charm/repository.py (right):
https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcod...
juju/charm/repository.py:130: host = url.split('/')[2]
this would be more robust with
urlparse.urlparse(url).hostname
https://codereview.appspot.com/6443090/diff/1/juju/charm/repository.py#newcod...
juju/charm/repository.py:152: host = url.split('/')[2]
same with this one.