Issue 6443063: Fix for devdraw on MacOS 10.8 (Mountain Lion)

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(89)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6443063: Fix for devdraw on MacOS 10.8 (Mountain Lion)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by robkroeger

Modified:
13 years, 5 months ago

Reviewers:

CC:
rsc, codebot

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -31 lines)			Patch
M	src/cmd/devdraw/cocoa-screen.m	View	10 chunks	+40 lines, -31 lines	0 comments	Download

Total messages: 4

robkroeger

13 years, 5 months ago (2012年07月31日 12:16:17 UTC) #1

robkroeger

In MacOS 10.8, the NSBitmapImageRep class appears to cache the specified image data at the ...

13 years, 5 months ago (2012年07月31日 12:19:11 UTC) #2

In MacOS 10.8, the NSBitmapImageRep class appears to cache the specified image
data at the time of construction. As a result updates to the backing memimage
object do not get pushed to the screen in flushimg.
This patch creates the NSBitmapImageRep object over again for each flushimg
which would appear to fix the problem.

rsc

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=c89c9c245071 *** devdraw: fix for OS X 10.8 (Mountain Lion) In MacOS ...

13 years, 5 months ago (2012年07月31日 15:24:51 UTC) #3

*** Submitted as http://code.google.com/p/plan9port/source/detail?r=c89c9c245071
***
devdraw: fix for OS X 10.8 (Mountain Lion)
In MacOS 10.8, the NSBitmapImageRep class appears to cache the specified
image data at the time of construction. As a result updates to the
backing memimage object do not get pushed to the screen in flushimg.
This patch creates the NSBitmapImageRep object over again for each
flushimg which would appear to fix the problem.
R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6443063
Committer: Russ Cox <rsc@swtch.com>

rsc

Thanks very much! I haven't taken the time to upgrade yet, but I confirmed that ...

13 years, 5 months ago (2012年07月31日 15:25:17 UTC) #4

Thanks very much! I haven't taken the time to upgrade yet, but I
confirmed that this works on Lion.

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b