Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(314)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6406045: code review 6406045: gotour: achievement system

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by tux21b
Modified:
12 years, 7 months ago
Reviewers:
adg, golang-dev, bradfitz
Visibility:
Public.
gotour: achievement system Added a simple achievement system to keep new gophers motivated. The achievement bubbles are displayed on the bottom right corner and multiple bubbles will stack automatically on top of each other. You can test this functionality by running the program on slide #14 with an empty localStorage. This CL only introduces 6 example achievements, but the plan is to add quite a lot of them. Feel free to propose additional achievements!

Patch Set 1 #

Patch Set 2 : diff -r ca1c030f0dfb https://code.google.com/p/go-tour #

Patch Set 3 : diff -r ca1c030f0dfb https://code.google.com/p/go-tour #

Created: 13 years, 6 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -5 lines) Patch
M gotour/goplay.go View 1 3 chunks +76 lines, -2 lines 0 comments Download
M static/index.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M static/playground.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M static/tour.css View 1 1 chunk +43 lines, -0 lines 0 comments Download
M static/tour.js View 1 4 chunks +51 lines, -2 lines 0 comments Download
Total messages: 3
|
tux21b
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
13 years, 6 months ago (2012年07月14日 20:50:44 UTC) #1
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go-tour 
Sign in to reply to this message.
adg
Hey, I did a similar thing here: http://codereview.appspot.com/5652075/ It has a more complex way to ...
13 years, 4 months ago (2012年08月27日 05:51:11 UTC) #2
Hey,
I did a similar thing here: http://codereview.appspot.com/5652075/
It has a more complex way to evaluate progress, and will check for common errors
and provide hints.
I've avoided responding to this CL for a while because I'm not sure how to
proceed. If we're going to introduce achievements, they should be well-designed
and valuable as a learning tool.
Not saying yours aren't. I just haven't digested your approach yet.
Sign in to reply to this message.
bradfitz
R=close I assume this no longer applies. I think adg still wants to do something ...
12 years, 7 months ago (2013年06月05日 20:52:35 UTC) #3
R=close
I assume this no longer applies. I think adg still wants to do something like
this eventually, so maybe this could be resurrected.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /