Issue 6348101: Benchmarking will now reset canvas so transfroms do not acculmulate.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(223)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6348101: Benchmarking will now reset canvas so transfroms do not acculmulate.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by keyar

Modified:
13 years, 6 months ago

Reviewers:
reed1, junov1, twiz

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Benchmarking will now reset canvas so transfroms do not acculmulate. The reset is performed by saving and restoring the canvases.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
M	tools/bench_pictures_main.cpp	View	3 chunks	+21 lines, -0 lines	0 comments	Download

Total messages: 4

keyar

13 years, 6 months ago (2012年07月12日 15:57:45 UTC) #1

reed1

SkCanvas::drawPicture already does this bracketing, and does it more safely, since it calls restoreToCount()

13 years, 6 months ago (2012年07月12日 16:03:03 UTC) #2

SkCanvas::drawPicture already does this bracketing, and does it more safely,
since it calls restoreToCount()

keyar

On 2012年07月12日 16:03:03, reed1 wrote: > SkCanvas::drawPicture already does this bracketing, and does it more ...

13 years, 6 months ago (2012年07月12日 17:28:19 UTC) #3

On 2012年07月12日 16:03:03, reed1 wrote:
> SkCanvas::drawPicture already does this bracketing, and does it more safely,
> since it calls restoreToCount()
Alright, disregard then.

junov1

On 2012年07月12日 17:28:19, keyar wrote: > On 2012年07月12日 16:03:03, reed1 wrote: > > SkCanvas::drawPicture already ...

13 years, 6 months ago (2012年07月12日 17:32:29 UTC) #4

On 2012年07月12日 17:28:19, keyar wrote:
> On 2012年07月12日 16:03:03, reed1 wrote:
> > SkCanvas::drawPicture already does this bracketing, and does it more safely,
> > since it calls restoreToCount()
> 
> Alright, disregard then.
What about pipe_run?

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b