Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6334045: proto: make safe for App Engine

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
Visibility:
Public.
proto: make safe for App Engine This depends on the proposed new reflect.Value method SetMem. If we allow SetMem to copy float32 to uint32 and float64 to uint64, then all the new functions outside pointer*.go can be removed.

Patch Set 1 #

Patch Set 2 : diff -r 8f20e710dc95 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 8f20e710dc95 https://code.google.com/p/goprotobuf #

Created: 13 years, 4 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+907 lines, -200 lines) Patch
M proto/decode.go View 1 2 17 chunks +290 lines, -59 lines 0 comments Download
M proto/encode.go View 1 2 22 chunks +282 lines, -64 lines 0 comments Download
M proto/extensions.go View 1 3 chunks +4 lines, -4 lines 0 comments Download
M proto/lib.go View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
A proto/pointer_reflect.go View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
A proto/pointer_unsafe.go View 1 2 1 chunk +102 lines, -0 lines 0 comments Download
M proto/properties.go View 1 2 10 chunks +99 lines, -70 lines 0 comments Download
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /