Issue 6332052: Make gtest work with libc++.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(375)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6332052: Make gtest work with libc++.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Jeffrey Yasskin

Modified:
12 years, 11 months ago

Reviewers:
michael181189

CC:
googletestframework_googlegroups.com

Visibility:
Public.

In C++11 mode, #include <tuple> unconditionally, and 'using' std::tuple and friends into std::tr1. In C++98 mode, libc++ doesn't define tuple<>, so force GTEST_USE_OWN_TR1_TUPLE.

Patch Set 1 #

Patch Set 2 : Set GTEST_USE_OWN_TR1_TUPLE for libc++ in C++98 mode. #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
M	include/gtest/internal/gtest-port.h	View	1	3 chunks	+29 lines, -8 lines	0 comments	Download

Total messages: 2

Jeffrey Yasskin

13 years, 6 months ago (2012年06月24日 02:22:57 UTC) #1

michael181189

Thanks. Did the trick with apple clang and std=c++11 -stdlib=libc++ which was broken because gtest ...

12 years, 11 months ago (2013年02月02日 22:09:08 UTC) #2

Thanks. Did the trick with apple clang and std=c++11 -stdlib=libc++ which was
broken because gtest looked for tr1/tuple instead of tuple
Michael