Issue 62710043: Fixes lp:1194902 JUJU_ENV not isolated in tests

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(232)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 62710043: Fixes lp:1194902 JUJU_ENV not isolated in tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by waigani

Modified:
11 years, 11 months ago

Reviewers:
mp+206069, axw

Visibility:
Public.

Fixes lp:1194902 JUJU_ENV not isolated in tests Patches JUJU_ENV with empty string https://code.launchpad.net/~waigani/juju-core/juju-env-test-isolation/+merge/206069 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/testing/conn.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4

waigani

Please take a look.

11 years, 11 months ago (2014年02月13日 01:03:04 UTC) #1

Please take a look.

axw

On 2014年02月13日 01:03:04, waigani wrote: > Please take a look. Have you tested this by ...

11 years, 11 months ago (2014年02月13日 08:50:48 UTC) #2

On 2014年02月13日 01:03:04, waigani wrote:
> Please take a look.
Have you tested this by setting JUJU_ENV? Are no other packages affected?

waigani

On 2014年02月13日 08:50:48, axw wrote: > On 2014年02月13日 01:03:04, waigani wrote: > > Please take ...

11 years, 11 months ago (2014年02月13日 21:21:19 UTC) #3

On 2014年02月13日 08:50:48, axw wrote:
> On 2014年02月13日 01:03:04, waigani wrote:
> > Please take a look.
> 
> Have you tested this by setting JUJU_ENV? Are no other packages affected?
I ran: JUJU_ENV="foobar" go test launchpad.net/juju-core/...
All tests passed.

axw

On 2014年02月13日 21:21:19, waigani wrote: > On 2014年02月13日 08:50:48, axw wrote: > > On 2014年02月13日 ...

11 years, 11 months ago (2014年02月14日 00:56:36 UTC) #4

On 2014年02月13日 21:21:19, waigani wrote:
> On 2014年02月13日 08:50:48, axw wrote:
> > On 2014年02月13日 01:03:04, waigani wrote:
> > > Please take a look.
> > 
> > Have you tested this by setting JUJU_ENV? Are no other packages affected?
> 
> I ran: JUJU_ENV="foobar" go test launchpad.net/juju-core/...
> 
> All tests passed.
Thanks for confirming. LGTM

RSS Feeds Recent Issues | This issue

This is Rietveld f62528b