Issue 6259049: Port r184840 from gcc-4_6.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(169)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6259049: Port r184840 from gcc-4_6.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by simonb

Modified:
13 years, 7 months ago

Reviewers:

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
M	contrib/testsuite-management/validate_failures.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2

simonb

Port r184840 from gcc-4_6. Forward-port r184840, contrib/testsuite-management/validate_failures.py fix for cross-compilers, from gcc-4_6 to gcc-4_7. Okay ...

13 years, 7 months ago (2012年05月28日 16:40:05 UTC) #1

Port r184840 from gcc-4_6.
Forward-port r184840, contrib/testsuite-management/validate_failures.py fix
for cross-compilers, from gcc-4_6 to gcc-4_7.
Okay for google/integration and google/gcc-4_7-integration branches?
2012年05月28日 Simon Baldwin <simonb@google.com>
	Port r184840 from gcc-4_6.
	2012年03月02日 Doug Kwan <dougkwan@google.com>
	Backport r184357 from trunk
		2012年02月17日 Doug Kwan <dougkwan@google.com>
		* contrib/testsuite-management/validate_failures.py
		(GetMakefileValue): Check for cross compilers.
Index: contrib/testsuite-management/validate_failures.py
===================================================================
--- contrib/testsuite-management/validate_failures.py	(revision 187932)
+++ contrib/testsuite-management/validate_failures.py	(working copy)
@@ -146,7 +146,8 @@ def GetMakefileValue(makefile_name, valu
 def ValidBuildDirectory(builddir, target):
 if (not os.path.exists(builddir) or
 not os.path.exists('%s/Makefile' % builddir) or
- not os.path.exists('%s/build-%s' % (builddir, target))):
+ (not os.path.exists('%s/build-%s' % (builddir, target)) and
+ not os.path.exists('%s/%s' % (builddir, target)))):
 return False
 return True
 
--
This patch is available for review at http://codereview.appspot.com/6259049

simonb

On 28 May 2012 18:40, Simon Baldwin <simonb@google.com> wrote: > > Port r184840 from gcc-4_6. ...

13 years, 7 months ago (2012年05月28日 16:41:45 UTC) #2

On 28 May 2012 18:40, Simon Baldwin <simonb@google.com> wrote:
>
> Port r184840 from gcc-4_6.
>
> Forward-port r184840, contrib/testsuite-management/validate_failures.py fix
> for cross-compilers, from gcc-4_6 to gcc-4_7.
>
> Okay for google/integration and google/gcc-4_7-integration branches?
That should have read "Okay for google/gcc-4_7?". Turns out it's
already in the others.
>
>
> 2012年05月28日 Simon Baldwin  <simonb@google.com>
>
>    Port r184840 from gcc-4_6.
>
>    2012年03月02日  Doug Kwan  <dougkwan@google.com>
>
>    Backport r184357 from trunk
>
>        2012年02月17日  Doug Kwan  <dougkwan@google.com>
>
>        * contrib/testsuite-management/validate_failures.py
>        (GetMakefileValue): Check for cross compilers.
>
>
> Index: contrib/testsuite-management/validate_failures.py
> ===================================================================
> --- contrib/testsuite-management/validate_failures.py  (revision 187932)
> +++ contrib/testsuite-management/validate_failures.py  (working copy)
> @@ -146,7 +146,8 @@ def GetMakefileValue(makefile_name, valu
> def ValidBuildDirectory(builddir, target):
>  if (not os.path.exists(builddir) or
>    not os.path.exists('%s/Makefile' % builddir) or
> -   not os.path.exists('%s/build-%s' % (builddir, target))):
> +   (not os.path.exists('%s/build-%s' % (builddir, target)) and
> +    not os.path.exists('%s/%s' % (builddir, target)))):
>   return False
>  return True
>
>
> --
> This patch is available for review at http://codereview.appspot.com/6259049
--
Google UK Limited | Registered Office: Belgrave House, 76 Buckingham
Palace Road, London SW1W 9TQ | Registered in England Number: 3977902