|
|
|
Created:
13 years, 8 months ago by ryanb Modified:
13 years, 7 months ago Reviewers:
Sameer Ajmani CC:
golang-dev, rsc, Sameer Ajmani, jba Visibility:
Public. |
misc/emacs: make compilation-mode's next-error understand test failure output.
specifically, adds a go-test element to compilation-error-regexp-alist[-alist].
Fixes issue 3629.
Patch Set 1 : misc/emacs: make next-error support test and panic output #Patch Set 2 : freshly synched copy of patch #1 #Patch Set 3 : new fresh patch (synched past issue 6213056's cl) #Total messages: 12
|
ryanb
hi all! this is pretty small and straightforward, and it fixes http://code.google.com/p/go/issues/detail?id=3629 . thanks in ...
|
13 years, 8 months ago (2012年05月16日 16:14:50 UTC) #1 |
hi all! this is pretty small and straightforward, and it fixes http://code.google.com/p/go/issues/detail?id=3629 . thanks in advance!
+jba
(actually +jba)
this update patch supports panic stack traces too.
LGTM
On 2012年05月31日 15:34:20, Sameer Ajmani wrote: > LGTM Hi Ryan, Please sync and upload a new patch set.
On Thu, May 31, 2012 at 8:39 AM, <sameer@golang.org> wrote: > > Please sync and upload a new patch set. thanks! done.
On 2012年05月31日 23:42:19, ryanb wrote: > On Thu, May 31, 2012 at 8:39 AM, <mailto:sameer@golang.org> wrote: > > > > Please sync and upload a new patch set. > > thanks! done. I still cannot patch your CL: $ hg clpatch 6197091 edit misc/emacs/go-mode.el: patch did not apply cleanly abort: hgpatch failed Not sure what's wrong with it; it looks fine to me.
On Fri, Jun 1, 2012 at 2:09 PM, <sameer@golang.org> wrote: > > I still cannot patch your CL: not sure how picky hgpatch is about line offsets, but maybe because you've patched in my other cl? :P i'll upload a clean patch for this cl, and i'll avoid parallel changes to the same file in the future.
*** Submitted as http://code.google.com/p/go/source/detail?r=f469c9d212c4 *** misc/emacs: make compilation-mode's next-error understand test failure output. specifically, adds a go-test element to compilation-error-regexp-alist[-alist]. Fixes issue 3629. R=golang-dev, rsc, sameer CC=golang-dev, jba http://codereview.appspot.com/6197091 Committer: Sameer Ajmani <sameer@golang.org>
thank you! i'm enjoying go so far, and good tool support helps a lot. these were both minor nits; overall, i'm really happy with (and grateful for) go-mode. On Mon, Jun 4, 2012 at 7:36 AM, <sameer@golang.org> wrote: > *** Submitted as > http://code.google.com/p/go/source/detail?r=f469c9d212c4 *** > > misc/emacs: make compilation-mode's next-error understand test failure > output. > > specifically, adds a go-test element to > compilation-error-regexp-alist[-alist]. > Fixes issue 3629. > > R=golang-dev, rsc, sameer > CC=golang-dev, jba > http://codereview.appspot.com/6197091 > > Committer: Sameer Ajmani <sameer@golang.org> > > > http://codereview.appspot.com/6197091/
I'm grateful to have people involved now who actually know elisp well :-) On Jun 4, 2012 11:04 AM, "Ryan Barrett" <ryanb@google.com> wrote: > thank you! i'm enjoying go so far, and good tool support helps a lot. > these were both minor nits; overall, i'm really happy with (and > grateful for) go-mode. > > On Mon, Jun 4, 2012 at 7:36 AM, <sameer@golang.org> wrote: > > *** Submitted as > > http://code.google.com/p/go/source/detail?r=f469c9d212c4 *** > > > > misc/emacs: make compilation-mode's next-error understand test failure > > output. > > > > specifically, adds a go-test element to > > compilation-error-regexp-alist[-alist]. > > Fixes issue 3629. > > > > R=golang-dev, rsc, sameer > > CC=golang-dev, jba > > http://codereview.appspot.com/6197091 > > > > Committer: Sameer Ajmani <sameer@golang.org> > > > > > > http://codereview.appspot.com/6197091/ >