|
|
|
Ensure Invoker.start is called from UnitRelationLifecycle usage.
UnitRelationLifecycle did not properly call Invoker.start (a one-line fix), which prevented relation hook contexts from being cached for the corresponding hook call. Because caching of the hook contexts is logged, this can be verified to ensure this method is properly called for both UnitRelationLifecycle and UnitLifecycle usages.
https://code.launchpad.net/~jimbaker/juju/unit-rel-lifecycle-start-invoker/+merge/104195
(do not edit description out of merge proposal)
Patch Set 1 #Patch Set 2 : Ensure Invoker.start is called from UnitRelationLifecycle usage. #
Total comments: 4
Total messages: 5
|
jimbaker
Please take a look.
|
13 years, 8 months ago (2012年05月01日 01:06:31 UTC) #1 | |||||||||||||||||||||||||||||||||||||||||||||
Please take a look.
Please take a look.
lgtm https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... File juju/unit/tests/test_lifecycle.py (right): https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... juju/unit/tests/test_lifecycle.py:901: for i in xrange(1, 3): don't use xrange, its of little value and dropped in py3. https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... juju/unit/tests/test_lifecycle.py:1331: for i in xrange(1, 5): ditto re xrange
Thanks, changed the minors and pushed accordingly https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... File juju/unit/tests/test_lifecycle.py (right): https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... juju/unit/tests/test_lifecycle.py:901: for i in xrange(1, 3): Pure habit here, fixed by using range instead https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... juju/unit/tests/test_lifecycle.py:1331: for i in xrange(1, 5): Ditto fix
looks good, pls go ahead w the merge. On 2012年05月04日 03:48:08, jimbaker wrote: > Thanks, changed the minors and pushed accordingly > > https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... > File juju/unit/tests/test_lifecycle.py (right): > > https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... > juju/unit/tests/test_lifecycle.py:901: for i in xrange(1, 3): > Pure habit here, fixed by using range instead > > https://codereview.appspot.com/6131061/diff/3001/juju/unit/tests/test_lifecyc... > juju/unit/tests/test_lifecycle.py:1331: for i in xrange(1, 5): > Ditto fix