Issue 61300043: code review 61300043: jwt: assertion time is not updated before JWT refresh

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(73)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 61300043: code review 61300043: jwt: assertion time is not updated before JWT refresh

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by karalabe

Modified:
11 years, 11 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

jwt: assertion time is not updated before JWT refresh The assertion and expiration time in the claim set do not get updated before fetching a new JWT, hence all refreshed tokens will already be expired.

Patch Set 1 #

Patch Set 2 : diff -r 5877582f0cb0 https://code.google.com/p/goauth2 #

Patch Set 3 : diff -r 5877582f0cb0 https://code.google.com/p/goauth2 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
M	oauth/jwt/jwt.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3

karalabe

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/goauth2

11 years, 11 months ago (2014年02月09日 21:01:01 UTC) #1

Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/goauth2

adg

LGTM

11 years, 11 months ago (2014年02月11日 06:23:58 UTC) #2

LGTM

adg

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=30c203fe2959 *** jwt: assertion time is not updated before JWT refresh The ...

11 years, 11 months ago (2014年02月11日 06:30:31 UTC) #3

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=30c203fe2959
***
jwt: assertion time is not updated before JWT refresh
The assertion and expiration time in the claim set do not get updated
before fetching a new JWT, hence all refreshed tokens will already be
expired.
LGTM=adg
R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/61300043
Committer: Andrew Gerrand <adg@golang.org>