Issue 6105052: Add support to Mexican VAT numbers to python-vatnumber

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(35)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6105052: Add support to Mexican VAT numbers to python-vatnumber

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by rsepulveda

Modified:
13 years, 8 months ago

Reviewers:
ced

Visibility:
Public.

More Reviews

Add support to Mexican VAT numbers to python-vatnumber

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix import location and add false tests. #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -0 lines)			Patch
M	vatnumber/__init__.py	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	vatnumber/tests.py	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 1

ced

https://codereview.appspot.com/6105052/diff/1/vatnumber/__init__.py File vatnumber/__init__.py (right): https://codereview.appspot.com/6105052/diff/1/vatnumber/__init__.py#newcode937 vatnumber/__init__.py:937: import time Import module on top of the file. ...

13 years, 8 months ago (2012年04月23日 15:01:10 UTC) #1

https://codereview.appspot.com/6105052/diff/1/vatnumber/__init__.py
File vatnumber/__init__.py (right):
https://codereview.appspot.com/6105052/diff/1/vatnumber/__init__.py#newcode937
vatnumber/__init__.py:937: import time
Import module on top of the file.
https://codereview.appspot.com/6105052/diff/1/vatnumber/tests.py
File vatnumber/tests.py (right):
https://codereview.appspot.com/6105052/diff/1/vatnumber/tests.py#newcode163
vatnumber/tests.py:163: ('MX', 'ABC123456AB4', True),
It will be good to have also False values.