Issue 5987057: namespace can be set via environment variable

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(6)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5987057: namespace can be set via environment variable

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by hazmat

Modified:
13 years, 9 months ago

Reviewers:
mp+101157

Visibility:
Public.

namespace can be set via environment variable This infers default values for scheme, user, series from the an env var for assembling a charm url based on what's provided on the cli for a charm name. Based on clint's namespace-from-env branch. Refactored the defaults extraction to a helper function. https://code.launchpad.net/~hazmat/juju/ns-from-env/+merge/101157 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1157 lines, -603 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/agents/machine.py	View	8 chunks	+9 lines, -74 lines	0 comments	Download
M	juju/agents/provision.py	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	juju/agents/tests/test_machine.py	View	7 chunks	+37 lines, -59 lines	0 comments	Download
M	juju/agents/tests/test_provision.py	View	11 chunks	+25 lines, -25 lines	0 comments	Download
M	juju/charm/tests/test_url.py	View	2 chunks	+40 lines, -26 lines	0 comments	Download
M	juju/charm/url.py	View	4 chunks	+41 lines, -33 lines	0 comments	Download
M	juju/control/remove_relation.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/control/tests/common.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/control/tests/test_add_unit.py	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	juju/control/tests/test_admin.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	juju/control/tests/test_config_set.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	juju/control/tests/test_debug_hooks.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	juju/control/tests/test_remove_unit.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	juju/control/tests/test_scp.py	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	juju/control/tests/test_ssh.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	juju/control/tests/test_status.py	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	juju/control/tests/test_terminate_machine.py	View	9 chunks	+13 lines, -26 lines	0 comments	Download
M	juju/control/tests/test_utils.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	juju/errors.py	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	juju/hooks/invoker.py	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	juju/hooks/scheduler.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	juju/hooks/tests/hooks/sleep-hook	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	juju/hooks/tests/test_cli.py	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	juju/hooks/tests/test_invoker.py	View	4 chunks	+15 lines, -15 lines	0 comments	Download
M	juju/hooks/tests/test_scheduler.py	View	4 chunks	+41 lines, -3 lines	0 comments	Download
M	juju/lib/testing.py	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	juju/lib/zklog.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/machine/constraints.py	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	juju/machine/tests/test_constraints.py	View	3 chunks	+9 lines, -11 lines	0 comments	Download
M	juju/providers/common/tests/test_cloudinit.py	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	juju/providers/ec2/securitygroup.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/providers/maas/provider.py	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	juju/providers/maas/tests/test_provider.py	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	juju/state/base.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	juju/state/initialize.py	View	4 chunks	+23 lines, -3 lines	0 comments	Download
M	juju/state/machine.py	View	3 chunks	+25 lines, -31 lines	0 comments	Download
M	juju/state/placement.py	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	juju/state/service.py	View	26 chunks	+97 lines, -124 lines	0 comments	Download
M	juju/state/tests/test_firewall.py	View	13 chunks	+18 lines, -21 lines	0 comments	Download
M	juju/state/tests/test_initialize.py	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	juju/state/tests/test_machine.py	View	28 chunks	+63 lines, -46 lines	0 comments	Download
M	juju/state/tests/test_placement.py	View	2 chunks	+27 lines, -10 lines	0 comments	Download
M	juju/state/tests/test_security.py	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	juju/state/tests/test_service.py	View	21 chunks	+91 lines, -24 lines	0 comments	Download
M	juju/state/tests/test_utils.py	View	2 chunks	+84 lines, -2 lines	0 comments	Download
M	juju/state/topology.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/state/utils.py	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	juju/tests/test_errors.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	juju/unit/charm.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	juju/unit/deploy.py	View	1 chunk	+104 lines, -0 lines	0 comments	Download
M	juju/unit/lifecycle.py	View	2 chunks	+4 lines, -1 line	0 comments	Download
A	juju/unit/tests/test_deploy.py	View	1 chunk	+149 lines, -0 lines	0 comments	Download
M	juju/unit/tests/test_lifecycle.py	View	4 chunks	+41 lines, -0 lines	0 comments	Download
M	juju/unit/tests/test_workflow.py	View	2 chunks	+38 lines, -0 lines	0 comments	Download

Total messages: 1

hazmat

Please take a look.

13 years, 9 months ago (2012年04月06日 21:16:16 UTC) #1

Please take a look.