|
|
|
make.bat: Fix for old files
Same fix as applied here: http://codereview.appspot.com/5761044
Fixes issue 3222.
Patch Set 1 #Patch Set 2 : diff -r 131ae87a607b https://go.googlecode.com/hg/ #Patch Set 3 : diff -r 131ae87a607b https://go.googlecode.com/hg/ #Total messages: 6
|
Topher
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
|
13 years, 10 months ago (2012年03月16日 00:13:19 UTC) #1 |
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
Your change looks good to me. But you name is not listed in CONTRIBUTORS file. You need to agree to contributor license agreement, before we can submit your change. See http://golang.org/doc/contribute.html#copyright for instructions. Alex
On 2012年03月16日 01:16:54, brainman wrote: > Your change looks good to me. But you name is not listed in CONTRIBUTORS file. > You need to agree to contributor license agreement, before we can submit your > change. See http://golang.org/doc/contribute.html#copyright for instructions. > > Alex Ah, looks like I missed a bit in the guide. Thanks.
I've added Christopher to the AUTHORS and CONTRIBUTORS files. Leaving this CL for Alex.
LGTM Thank you. Alex
*** Submitted as http://code.google.com/p/go/source/detail?r=d77371d5c280 *** make.bat: Fix for old files Same fix as applied here: http://codereview.appspot.com/5761044 Fixes issue 3222. R=golang-dev, alex.brainman, rsc CC=golang-dev http://codereview.appspot.com/5838043 Committer: Alex Brainman <alex.brainman@gmail.com>