|
|
|
Created:
13 years, 10 months ago by Ali Afshar Modified:
13 years, 10 months ago Reviewers:
jcgregorio_google CC:
google-api-python-client_googlegroups.com Visibility:
Public. |
Patch Set 1 #
Total messages: 4
|
jcgregorio_google
lgtm
|
13 years, 10 months ago (2012年03月12日 12:41:03 UTC) #1 | |||||||||||||||||||||
lgtm
Submitted in http://code.google.com/p/google-api-python-client/source/detail?r=7e4b0d56e5f... On Mon, Mar 12, 2012 at 8:41 AM, <jcgregorio@google.com> wrote: > lgtm > > http://codereview.appspot.com/**5796044/<http://codereview.appspot.com/5796044/> > -- Ali Afshar | www.googplus.org/ali | Google Developer Relations
For future reference please follow the guidelines for submitting code: http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S... <http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S...> Which includes adding a reference to the codereview in the commit message. On Mon, Mar 12, 2012 at 9:18 AM, Ali Afshar <afshar@google.com> wrote: > Submitted in > http://code.google.com/p/google-api-python-client/source/detail?r=7e4b0d56e5f... > > On Mon, Mar 12, 2012 at 8:41 AM, <jcgregorio@google.com> wrote: > >> lgtm >> >> http://codereview.appspot.com/**5796044/<http://codereview.appspot.com/5796044/> >> > > > > -- > Ali Afshar | www.googplus.org/ali | Google Developer Relations > >
Yikes sorry! Thanks, will do. On Mon, Mar 12, 2012 at 9:30 AM, Joe Gregorio <jcgregorio@google.com> wrote: > For future reference please follow the guidelines for submitting code: > > http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S... <http://code.google.com/p/google-api-python-client/wiki/BecomingAContributor#S...> > > Which includes adding a reference to the codereview in the commit message. > > > > On Mon, Mar 12, 2012 at 9:18 AM, Ali Afshar <afshar@google.com> wrote: > >> Submitted in >> http://code.google.com/p/google-api-python-client/source/detail?r=7e4b0d56e5f... >> >> On Mon, Mar 12, 2012 at 8:41 AM, <jcgregorio@google.com> wrote: >> >>> lgtm >>> >>> http://codereview.appspot.com/**5796044/<http://codereview.appspot.com/5796044/> >>> >> >> >> >> -- >> Ali Afshar | www.googplus.org/ali | Google Developer Relations >> >> > -- Ali Afshar | www.googplus.org/ali | Google Developer Relations