Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(317)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Unified Diff: examples/rietveld/patches/upload.diff

Issue 5787056: Fix problem with Perforce in upload.py
Patch Set: Created 13 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
('e') | ('c') | ('s')
Index: examples/rietveld/patches/upload.diff
===================================================================
--- a/examples/rietveld/patches/upload.diff
+++ b/examples/rietveld/patches/upload.diff
@@ -91,3 +91,13 @@
def GetUserCredentials():
"""Prompts the user for a username and password."""
+@@ -1600,6 +1600,8 @@ class PerforceVCS(VersionControlSystem):
+ if marshal_output:
+ # -G makes perforce format its output as marshalled python objects
+ args.extend(["-G"])
++ # you should NEVER use universal_newlines with marshalled objects
++ universal_newlines = False
+ if self.p4_port:
+ args.extend(["-p", self.p4_port])
+ if self.p4_client:
+
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /