Issue 5706057: Bundle extraction in place should handle symlinks.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(348)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5706057: Bundle extraction in place should handle symlinks.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by hazmat

Modified:
13 years, 10 months ago

Reviewers:
mp+95098, bcsaller

Visibility:
Public.

Previously extraction in place would fail on symlink extraction if the symlink already existed. As is this fix doesn't catch odder cases like directories changing into symlinks. But then neither did the previous extract in place. A longer term solution would be to have install manifests, and delta them against existing on disk state as part of charm upgrade. https://code.launchpad.net/~hazmat/juju/upgrade-sym-link/+merge/95098 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
M	juju/charm/bundle.py	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	juju/charm/tests/test_bundle.py	View	3 chunks	+13 lines, -3 lines	1 comment	Download

Total messages: 2

hazmat

Please take a look.

13 years, 10 months ago (2012年02月29日 03:55:21 UTC) #1

Please take a look.

bcsaller

lgtm https://codereview.appspot.com/5706057/diff/1/juju/charm/tests/test_bundle.py File juju/charm/tests/test_bundle.py (right): https://codereview.appspot.com/5706057/diff/1/juju/charm/tests/test_bundle.py#newcode178 juju/charm/tests/test_bundle.py:178: os.symlink('./metadata.yaml', sym_path) why ./ here rather than a ...

13 years, 10 months ago (2012年02月29日 22:39:01 UTC) #2

lgtm
https://codereview.appspot.com/5706057/diff/1/juju/charm/tests/test_bundle.py
File juju/charm/tests/test_bundle.py (right):
https://codereview.appspot.com/5706057/diff/1/juju/charm/tests/test_bundle.py...
juju/charm/tests/test_bundle.py:178: os.symlink('./metadata.yaml', sym_path)
why ./ here rather than a bare filename?