|
|
|
Created:
13 years, 10 months ago by Kyle E. Lemons Modified:
12 years, 5 months ago Reviewers:
adg CC:
adg, rsc, kevlar, golang-dev Visibility:
Public. |
gotour: save to HTML5 LocalStorage
This change adds LocalStorage to persist both the code that the
user has created and the page the user last visited. To facilitate
the first, a [RESET] button was added in the lower corner.
Fixes issue 2.
Fixes issue 16.
Patch Set 1 #Patch Set 2 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 3 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 4 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 5 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 6 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 7 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 8 : diff -r 72d926d8e6ae https://code.google.com/p/go-tour #Patch Set 9 : diff -r 54cbfe4db35c https://code.google.com/p/go-tour #Total messages: 20
|
Kyle E. Lemons
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour
|
13 years, 10 months ago (2012年02月26日 21:59:26 UTC) #1 |
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour
Thanks for doing this. It would be much better if the RESET button were adjacent to RUN. Can you do that?
PTAL On 2012年02月28日 00:07:34, adg wrote: > Thanks for doing this. > > It would be much better if the RESET button were adjacent to RUN. Can you do > that? Ah, yes, that would make more sense. I made it [RESET] [RUN] since that moves the run button the least from its original position.
On 2012年02月28日 02:19:37, Kyle E. Lemons wrote: > PTAL > > On 2012年02月28日 00:07:34, adg wrote: > > Thanks for doing this. > > > > It would be much better if the RESET button were adjacent to RUN. Can you do > > that? > > Ah, yes, that would make more sense. I made it [RESET] [RUN] since that moves > the run button the least from its original position. Eh, hold on, I messed something up when you first visit.
I noticed that too, but I couldn't reproduce it in incognito. On 28 February 2012 13:23, <kyle@kylelemons.net> wrote: > On 2012年02月28日 02:19:37, Kyle E. Lemons wrote: >> >> PTAL > > >> On 2012年02月28日 00:07:34, adg wrote: >> > Thanks for doing this. >> > >> > It would be much better if the RESET button were adjacent to RUN. > > Can you do >> >> > that? > > >> Ah, yes, that would make more sense. I made it [RESET] [RUN] since > > that moves >> >> the run button the least from its original position. > > > Eh, hold on, I messed something up when you first visit. > > http://codereview.appspot.com/5695068/
On 2012年02月28日 02:23:50, Kyle E. Lemons wrote: > On 2012年02月28日 02:19:37, Kyle E. Lemons wrote: > > PTAL > > > > On 2012年02月28日 00:07:34, adg wrote: > > > Thanks for doing this. > > > > > > It would be much better if the RESET button were adjacent to RUN. Can you do > > > that? > > > > Ah, yes, that would make more sense. I made it [RESET] [RUN] since that moves > > the run button the least from its original position. > > Eh, hold on, I messed something up when you first visit. Okay, fixed. I'd forgotten a return. Tested in Firefox, Safari, and Chrome on my mac. PTAL
On Mon, Feb 27, 2012 at 19:07, <adg@golang.org> wrote: > It would be much better if the RESET button were adjacent to RUN. I haven't looked at the actual CL but it seems to me that it would be best if RESET were nowhere near RUN, to prevent accidental clicks.
> > On Mon, Feb 27, 2012 at 19:07, <adg@golang.org> wrote: > > It would be much better if the RESET button were adjacent to RUN. > > I haven't looked at the actual CL but it seems to me that it > would be best if RESET were nowhere near RUN, to prevent > accidental clicks. > Is putting it between PREV and NEXT sensible? I initially put it there because up top looked like it would reset the whole tour (which is doable, bit I think less desired) and that seemed like an easy place to put something slide-specific.
I would put it in some out of the way corner not near any other buttons, so that the mouse would not be over there unless it was trying to get to RESET.
> > I would put it in some out of the way corner not near any other buttons, > so that the mouse would not be over there unless it was trying to get > to RESET. > Lower right corner of the code box, then?
PTAL. I have moved RESET to the lower right corner. Surprisingly, this actually works nowadays in Chrome, Firefox, and Safari (on my mac, at least). I can't say if any of this works on IE or not; I don't have one handy. On 2012年02月28日 18:15:06, kevlar wrote: > > > > I would put it in some out of the way corner not near any other buttons, > > so that the mouse would not be over there unless it was trying to get > > to RESET. > > > > Lower right corner of the code box, then?
ping
Ping Sync'd and merged.
ping (would there be a better time to put this CL forward?)
On Tue, May 1, 2012 at 13:19, <kevlar@google.com> wrote: > ping (would there be a better time to put this CL forward?) adg has been offline/traveling, and we're all a bit behind on mail. we'll get to it. sorry for the delay.
It's on my list, it's just below a few other important things. Thanks for your patience.
LGTM
*** Submitted as http://code.google.com/p/go-tour/source/detail?r=e057b1ee4434 *** gotour: save to HTML5 LocalStorage This change adds LocalStorage to persist both the code that the user has created and the page the user last visited. To facilitate the first, a [RESET] button was added in the lower corner. Fixes issue 2. Fixes issue 16. R=adg, rsc, kevlar CC=golang-dev http://codereview.appspot.com/5695068 Committer: Andrew Gerrand <adg@golang.org>