Issue 569041: Free jit_code_entrys from the JITDebugRegisterer

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(121)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 569041: Free jit_code_entrys from the JITDebugRegisterer

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by Jeffrey Yasskin

Modified:
15 years, 10 months ago

Reviewers:
Reid Kleckner

Base URL:
https://llvm.org/svn/llvm-project/llvm/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
M	lib/ExecutionEngine/JIT/JITDebugRegisterer.cpp	View	2 chunks	+4 lines, -1 line	1 comment	Download

Total messages: 3

Jeffrey Yasskin

Am I going to break anything by doing this? I believe it's the last memory ...

15 years, 10 months ago (2010年03月15日 17:03:31 UTC) #1

Am I going to break anything by doing this? I believe it's the last memory leak
in the LLVM unittests.

Reid Kleckner

Nope, looks good to me. GDB doesn't hold pointers to entries in the inferior. http://codereview.appspot.com/569041/diff/1/2 ...

15 years, 10 months ago (2010年03月16日 05:23:42 UTC) #2

Nope, looks good to me. GDB doesn't hold pointers to entries in the inferior.
http://codereview.appspot.com/569041/diff/1/2
File lib/ExecutionEngine/JIT/JITDebugRegisterer.cpp (right):
http://codereview.appspot.com/569041/diff/1/2#newcode194
lib/ExecutionEngine/JIT/JITDebugRegisterer.cpp:194: JITCodeEntry = NULL;
If you want to erase dangling pointers, there's also the relevant_entry field of
the descriptor.

Jeffrey Yasskin

On Mon, Mar 15, 2010 at 10:23 PM, <reid.kleckner@gmail.com> wrote: > Nope, looks good to ...

15 years, 10 months ago (2010年03月16日 05:56:39 UTC) #3

On Mon, Mar 15, 2010 at 10:23 PM, <reid.kleckner@gmail.com> wrote:
> Nope, looks good to me. GDB doesn't hold pointers to entries in the
> inferior.
Cool, thanks.
> http://codereview.appspot.com/569041/diff/1/2
> File lib/ExecutionEngine/JIT/JITDebugRegisterer.cpp (right):
>
> http://codereview.appspot.com/569041/diff/1/2#newcode194
> lib/ExecutionEngine/JIT/JITDebugRegisterer.cpp:194: JITCodeEntry = NULL;
> If you want to erase dangling pointers, there's also the relevant_entry
> field of the descriptor.
That one's never read from llvm code, so I don't care as much.