Issue 5686061: Fix issue #29 in gae2django

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(68)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5686061: Fix issue #29 in gae2django

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by rick446.RC

Modified:
13 years, 10 months ago

Reviewers:
Andi Albrecht

CC:
gae2django_googlegroups.com

Visibility:
Public.

More Reviews

Fix issue #29 in gae2django

Patch Set 1 #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
M	.hgignore	View	1 chunk	+4 lines, -1 line	1 comment	Download
M	gae2django/gaeapi/appengine/ext/db.py	View	3 chunks	+16 lines, -4 lines	0 comments	Download

Total messages: 2

rick446.RC

13 years, 10 months ago (2012年02月21日 20:45:27 UTC) #1

Andi Albrecht

LGTM I've committed it already, except for the .hgignore change. Thanks, again! http://codereview.appspot.com/5686061/diff/1/.hgignore File .hgignore ...

13 years, 10 months ago (2012年02月22日 18:39:30 UTC) #2

LGTM
I've committed it already, except for the .hgignore change.
Thanks, again!
http://codereview.appspot.com/5686061/diff/1/.hgignore
File .hgignore (right):
http://codereview.appspot.com/5686061/diff/1/.hgignore#newcode15
.hgignore:15: *.pyc
I ignore this change. This is something that's usually found in ~/.hgignore and
not project dependent.