|
|
|
Refactored Juju Run
Proxy env vars are passed into unit context i.e.
`[ -f "/home/ubuntu/.juju-proxy" ] && . "/home/ubuntu/.juju-proxy"`
is prepended to juju run cmd inside RunCommand.executeInUnitContext method
https://code.launchpad.net/~waigani/juju-core/refactor-juju-run/+merge/202792
(do not edit description out of merge proposal)
Patch Set 1 #
Total messages: 4
|
waigani
Please take a look.
|
11 years, 11 months ago (2014年01月23日 06:20:01 UTC) #1 | ||||||||||||||||||||||||||||||||
Please take a look.
These look good. We were also going to check the err response from the fslock Lock method.
On 2014年01月23日 20:55:19, thumper wrote:
> These look good.
>
> We were also going to check the err response from the fslock Lock method.
In run_test.go I've written:
func (s *RunTestSuite) TestGetLock(c *gc.C) {
_, err := getLock()
c.Assert(err, gc.ErrorMatches, "mkdir /var/lib/juju/locks: permission denied")
}
Is this what you meant? It passes, but I don't know if "mkdir
/var/lib/juju/locks: permission denied" is expected. I don't understand the
problem / remember why/how we were going to test the fslock?
On 2014年01月27日 09:27:38, waigani wrote:
> On 2014年01月23日 20:55:19, thumper wrote:
> > These look good.
> >
> > We were also going to check the err response from the fslock Lock method.
>
> In run_test.go I've written:
>
> func (s *RunTestSuite) TestGetLock(c *gc.C) {
> _, err := getLock()
> c.Assert(err, gc.ErrorMatches, "mkdir /var/lib/juju/locks: permission
denied")
> }
>
> Is this what you meant? It passes, but I don't know if "mkdir
> /var/lib/juju/locks: permission denied" is expected. I don't understand the
> problem / remember why/how we were going to test the fslock?
Yes that is expected, and there is already another bug outstanding for that.
LGTM