|
|
|
Created:
13 years, 11 months ago by Kaelyn Modified:
13 years, 11 months ago Reviewers:
kyrtzidis CC:
cfe-commits_cs.uiuc.edu Visibility:
Public. |
Pass a typo correction callback object from ParseCastExpr to Sema::ActOnIdExpression to be a bit more selective about what kinds of corrections will be allowed for unknown identifiers.
Patch Set 1 #
Total messages: 3
|
Kaelyn
|
13 years, 11 months ago (2012年01月23日 20:45:59 UTC) #1 | |||||||||||||||||||||||||||||||||||||||||||||||||
Ping? I'd at least like someone more familiar with the parser to give this patch a once-over before committing it. Thanks, Kaelyn On Mon, Jan 23, 2012 at 12:45 PM, <rikka@google.com> wrote: > Reviewers: kyrtzidis_apple.com, > > Description: > Pass a typo correction callback object from ParseCastExpr to > Sema::ActOnIdExpression to be a bit more selective about what kinds of > corrections will be allowed for unknown identifiers. > > Please review this at http://codereview.appspot.com/**5572049/<http://codereview.appspot.com/5572049/> > > Affected files: > M include/clang/Parse/Parser.h > M include/clang/Sema/Sema.h > M lib/Parse/ParseExpr.cpp > M lib/Parse/ParseExprCXX.cpp > M lib/Sema/SemaExpr.cpp > M test/SemaCXX/typo-correction.**cpp > > >
LGTM! On Jan 25, 2012, at 10:49 AM, Kaelyn Uhrain wrote: > Ping? I'd at least like someone more familiar with the parser to give this patch a once-over before committing it. > > Thanks, > Kaelyn > > On Mon, Jan 23, 2012 at 12:45 PM, <rikka@google.com> wrote: > Reviewers: kyrtzidis_apple.com, > > Description: > Pass a typo correction callback object from ParseCastExpr to > Sema::ActOnIdExpression to be a bit more selective about what kinds of > corrections will be allowed for unknown identifiers. > > Please review this at http://codereview.appspot.com/5572049/ > > Affected files: > M include/clang/Parse/Parser.h > M include/clang/Sema/Sema.h > M lib/Parse/ParseExpr.cpp > M lib/Parse/ParseExprCXX.cpp > M lib/Sema/SemaExpr.cpp > M test/SemaCXX/typo-correction.cpp > > >