Issue 5556059: Template instantiation of dependent attributes II

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(26)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5556059: Template instantiation of dependent attributes II

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by delesley

Modified:
13 years, 11 months ago

Reviewers:
chandlerc

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 4

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+338 lines, -18 lines)			Patch
M	include/clang/Basic/Attr.td	View	4 chunks	+15 lines, -0 lines	0 comments	Download
M	include/clang/CMakeLists.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/clang/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
A	include/clang/Sema/CMakeLists.txt	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	include/clang/Sema/Makefile	View	1 chunk	+14 lines, -0 lines	4 comments	Download
M	lib/Sema/CMakeLists.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/Sema/SemaDecl.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/Sema/SemaDeclAttr.cpp	View	1 chunk	+5 lines, -7 lines	0 comments	Download
M	lib/Sema/SemaTemplateInstantiateDecl.cpp	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	test/SemaCXX/warn-thread-safety-analysis.cpp	View	3 chunks	+127 lines, -3 lines	0 comments	Download
M	utils/TableGen/ClangAttrEmitter.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	utils/TableGen/ClangAttrEmitter.cpp	View	12 chunks	+141 lines, -3 lines	0 comments	Download
M	utils/TableGen/TableGen.cpp	View	3 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 3

chandlerc

Tiny, horribly nit-picky whitespace comments. =D The build changes look fine. http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile File include/clang/Sema/Makefile (right): ...

13 years, 11 months ago (2012年01月20日 19:45:22 UTC) #1

Tiny, horribly nit-picky whitespace comments. =D The build changes look fine.
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile
File include/clang/Sema/Makefile (right):
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
include/clang/Sema/Makefile:10: $(CLANG_TBLGEN) $(ObjDir)/.dir
Despite the failure to do this in the file you likely based this off of, I'd
appreciate it if you line the first $ here with the $ after the : above.
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
include/clang/Sema/Makefile:13: $(call SYSPATH, $@) -I $(PROJ_SRC_DIR)/../../ $<
And I think this is more commonly 1 tabe and 2 spaces indent. Yea, I know, I'm
the most nitpicky person ever... sorry...

delesley

I don't mind nitpicky comments, so long as an LGTM comes at the end. :-) ...

13 years, 11 months ago (2012年01月20日 22:14:19 UTC) #2

I don't mind nitpicky comments, so long as an LGTM comes at the end. :-) 
On 2012年01月20日 19:45:22, chandlerc wrote:
> Tiny, horribly nit-picky whitespace comments. =D The build changes look fine.
> 
> http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile
> File include/clang/Sema/Makefile (right):
> 
>
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
> include/clang/Sema/Makefile:10: $(CLANG_TBLGEN) $(ObjDir)/.dir
> Despite the failure to do this in the file you likely based this off of, I'd
> appreciate it if you line the first $ here with the $ after the : above.
> 
>
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
> include/clang/Sema/Makefile:13: $(call SYSPATH, $@) -I $(PROJ_SRC_DIR)/../../
$<
> And I think this is more commonly 1 tabe and 2 spaces indent. Yea, I know, I'm
> the most nitpicky person ever... sorry...

delesley

I don't mind nitpicky comments, so long as an LGTM comes at the end. :-) ...

13 years, 11 months ago (2012年01月20日 22:15:08 UTC) #3

I don't mind nitpicky comments, so long as an LGTM comes at the end. :-)
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile
File include/clang/Sema/Makefile (right):
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
include/clang/Sema/Makefile:10: $(CLANG_TBLGEN) $(ObjDir)/.dir
On 2012年01月20日 19:45:22, chandlerc wrote:
> Despite the failure to do this in the file you likely based this off of, I'd
> appreciate it if you line the first $ here with the $ after the : above.
Done.
http://codereview.appspot.com/5556059/diff/1/include/clang/Sema/Makefile#newc...
include/clang/Sema/Makefile:13: $(call SYSPATH, $@) -I $(PROJ_SRC_DIR)/../../ $<
On 2012年01月20日 19:45:22, chandlerc wrote:
> And I think this is more commonly 1 tabe and 2 spaces indent. Yea, I know, I'm
> the most nitpicky person ever... sorry...
Done.