Keyboard Shortcuts

File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5552057: code review 5552057: runtime: runtime-gdb.py disable ifacematcher for windows.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by vcc
Modified:
13 years, 11 months ago
Reviewers:
lvd, golang-dev
Visibility:
Public.
runtime: runtime-gdb.py disable ifacematcher for windows.

Patch Set 1 #

Patch Set 2 : diff -r b7e029136522 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b7e029136522 http://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/runtime/runtime-gdb.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
Total messages: 3
|
vcc
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/
13 years, 11 months ago (2012年01月31日 13:19:24 UTC) #1
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
http://go.googlecode.com/hg/ 
Sign in to reply to this message.
vcc
gdb 7.4 improve python support, can auto load runtime-gdb.py in windows now, but don't work ...
13 years, 11 months ago (2012年01月31日 13:26:06 UTC) #2
gdb 7.4 improve python support, can auto load runtime-gdb.py in
windows now, but don't work with ifacematcher.
in is_iface function:
def is_iface(val):
	try:
		return str(val['tab'].type) == "struct runtime.itab *" \
		 and str(val['data'].type) == "void *"
	except:
		pass
type(val) is int, val['tab'].type make gdb crash.
my gdb 7.4 build for windows can download from
<http://code.google.com/p/go-w64/downloads/list>
2012年1月31日 <vcc.163@gmail.com>:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> http://go.googlecode.com/hg/
>
>
> Description:
> runtime: runtime-gdb.py disable ifacematcher for windows.
>
> Please review this at http://codereview.appspot.com/5552057/
>
> Affected files:
> M src/pkg/runtime/runtime-gdb.py
>
>
> Index: src/pkg/runtime/runtime-gdb.py
> ===================================================================
> --- a/src/pkg/runtime/runtime-gdb.py
> +++ b/src/pkg/runtime/runtime-gdb.py
> @@ -15,7 +15,7 @@
> #   circumventing the pretty print triggering.
>
>
> -import sys, re
> +import sys, re, os
>
> print >>sys.stderr, "Loading Go Runtime support."
>
> @@ -258,7 +258,8 @@
>    if is_iface(val) or is_eface(val):
>        return IfacePrinter(val)
>
> -goobjfile.pretty_printers.append(ifacematcher)
> +if os.name != 'nt':
> +    goobjfile.pretty_printers.append(ifacematcher)
>
> #
> # Convenience Functions
>
>
Sign in to reply to this message.
lvd
On Tue, Jan 31, 2012 at 14:26, Wei guangjing <vcc.163@gmail.com> wrote: > gdb 7.4 improve ...
13 years, 11 months ago (2012年01月31日 13:51:41 UTC) #3
On Tue, Jan 31, 2012 at 14:26, Wei guangjing <vcc.163@gmail.com> wrote:
> gdb 7.4 improve python support, can auto load runtime-gdb.py in
> windows now, but don't work with ifacematcher.
> in is_iface function:
> def is_iface(val):
>    try:
>        return str(val['tab'].type) == "struct runtime.itab *" \
>           and str(val['data'].type) == "void *"
>    except:
>        pass
>
> type(val) is int, val['tab'].type make gdb crash.
i would have expected python to just throw an exception.
anyways, i'd like to fix the root cause, which i suspect is related to
the dwarf representation i chose for interfaces. is there a way you
can send me a dump of the dwarfinfo from a windows binary?
>
> my gdb 7.4 build for windows can download from
> <http://code.google.com/p/go-w64/downloads/list>
>
> 2012年1月31日  <vcc.163@gmail.com>:
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> http://go.googlecode.com/hg/
>>
>>
>> Description:
>> runtime: runtime-gdb.py disable ifacematcher for windows.
>>
>> Please review this at http://codereview.appspot.com/5552057/
>>
>> Affected files:
>> M src/pkg/runtime/runtime-gdb.py
>>
>>
>> Index: src/pkg/runtime/runtime-gdb.py
>> ===================================================================
>> --- a/src/pkg/runtime/runtime-gdb.py
>> +++ b/src/pkg/runtime/runtime-gdb.py
>> @@ -15,7 +15,7 @@
>> #   circumventing the pretty print triggering.
>>
>>
>> -import sys, re
>> +import sys, re, os
>>
>> print >>sys.stderr, "Loading Go Runtime support."
>>
>> @@ -258,7 +258,8 @@
>>    if is_iface(val) or is_eface(val):
>>        return IfacePrinter(val)
>>
>> -goobjfile.pretty_printers.append(ifacematcher)
>> +if os.name != 'nt':
>> +    goobjfile.pretty_printers.append(ifacematcher)
>>
>> #
>> # Convenience Functions
>>
>>
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /