|
|
|
syscall: add constants for flock() system call under Linux.
The values have been generated only for the i386 and amd64 architectures.
Patch Set 1 #Patch Set 2 : diff -r 778c06919be6 https://go.googlecode.com/hg/ #Patch Set 3 : diff -r 778c06919be6 https://go.googlecode.com/hg/ #
Total comments: 2
Patch Set 4 : diff -r 778c06919be6 https://go.googlecode.com/hg/ #
Total messages: 9
|
spadaccio
Hello golang-dev@googlegroups.com (cc: bradfitz@google.com, dsymonds@google.com, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
|
14 years, 1 month ago (2011年12月06日 22:53:23 UTC) #1 | ||||||||||||||||||||||||||||||||
Hello golang-dev@googlegroups.com (cc: bradfitz@google.com, dsymonds@google.com, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh#n... src/pkg/syscall/mkerrors.sh:26: #include <sys/file.h> might be better not only for Linux. e.g., includes=' #include <dirent.h> #include <errno.h> #include <fcntl.h> #include <sys/file.h> #include <sys/resource.h> #include <sys/socket.h> #include <sys/types.h> #include <netinet/in.h> #include <netinet/ip.h> #include <netinet/ip6.h> #include <netinet/tcp.h> #include <signal.h> #include <sys/signal.h> '
Hello golang-dev@googlegroups.com, mikioh.mikioh@gmail.com (cc: bradfitz@google.com, dsymonds@google.com, golang-dev@googlegroups.com), Please take another look.
http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh File src/pkg/syscall/mkerrors.sh (right): http://codereview.appspot.com/5452060/diff/2002/src/pkg/syscall/mkerrors.sh#n... src/pkg/syscall/mkerrors.sh:26: #include <sys/file.h> On 2011年12月07日 05:25:11, mikioh wrote: > might be better not only for Linux. > > e.g., > includes=' > #include <dirent.h> > #include <errno.h> > #include <fcntl.h> > #include <sys/file.h> > #include <sys/resource.h> > #include <sys/socket.h> > #include <sys/types.h> > #include <netinet/in.h> > #include <netinet/ip.h> > #include <netinet/ip6.h> > #include <netinet/tcp.h> > #include <signal.h> > #include <sys/signal.h> > ' Done.
LGTM
Hello, Does anybody his colleague be able to proceed corporate contributor license agreement for him? Thx.
On Thu, Dec 8, 2011 at 3:47 PM, <mikioh.mikioh@gmail.com> wrote: > Does anybody his colleague be able to proceed corporate contributor > license agreement for him? I'll get it.
Thank you. On 2011年12月08日 04:49:41, dsymonds wrote: > On Thu, Dec 8, 2011 at 3:47 PM, <mailto:mikioh.mikioh@gmail.com> wrote: > > > Does anybody his colleague be able to proceed corporate contributor > > license agreement for him? > > I'll get it.
*** Submitted as http://code.google.com/p/go/source/detail?r=5190380293e8 *** syscall: add constants for flock() system call under Linux. The values have been generated only for the i386 and amd64 architectures. R=golang-dev, mikioh.mikioh, dsymonds CC=bradfitz, dsymonds, golang-dev http://codereview.appspot.com/5452060 Committer: Mikio Hara <mikioh.mikioh@gmail.com>