Keyboard Shortcuts
File
u :up to issue
m :publish + mail comments
M :edit review message
j / k :jump to file after / before current file
J / K :jump to next file with a comment after / before current file
Side-by-side diff
i :toggle intra-line diffs
e :expand all comments
c :collapse all comments
s :toggle showing all comments
n / p :next / previous diff chunk or comment
N / P :next / previous comment
<Up> / <Down> :next / previous line
<Enter> :respond to / edit current comment
d :mark current comment as done
Issue
u :up to list of issues
m :publish + mail comments
j / k :jump to patch after / before current patch
o / <Enter> :open current patch in side-by-side view
i :open current patch in unified diff view
Issue List
j / k :jump to issue after / before current issue
o / <Enter> :open current issue
# : close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :save comment
<Esc> :cancel edit
Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(474)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5450059: code review 5450059: exp/ssh: export type signal. Renamed to Signal

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by gpaul
Modified:
14 years, 1 month ago
Reviewers:
agl1 , rsc , niemeyer
CC:
dave_cheney.net, agl1, rsc, golang-dev_googlgroups.com, golang-dev
Visibility:
Public.
exp/ssh: export type signal. Renamed to Signal

Patch Set 1 #

Patch Set 2 : diff -r 16f9f293a550 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 16f9f293a550 https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago
Download [raw] [tar.bz2]
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M src/pkg/exp/ssh/session.go View 1 7 chunks +32 lines, -32 lines 0 comments Download
Total messages: 6
|
gpaul
Hello dave@cheney.net, agl@golang.org, rsc@golang.org, golang-dev@googlgroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
14 years, 1 month ago (2011年12月01日 14:00:33 UTC) #1 
Hello dave@cheney.net, agl@golang.org, rsc@golang.org,
golang-dev@googlgroups.com (cc: golang-dev@googlegroups.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Sign in to reply to this message.
agl1
LGTM. I'll wait for rsc to take a quick look as I think it was ...
14 years, 1 month ago (2011年12月01日 16:04:29 UTC) #2 
LGTM. I'll wait for rsc to take a quick look as I think it was his suggestion.
Sign in to reply to this message.
niemeyer
> LGTM. I'll wait for rsc to take a quick look as I think it ...
14 years, 1 month ago (2011年12月01日 18:55:24 UTC) #3 
> LGTM. I'll wait for rsc to take a quick look as I think it was his suggestion.
LGTM too.
He just asked for the type to be published. Should be fine to go ahead.
Sign in to reply to this message.
rsc
LGTM
14 years, 1 month ago (2011年12月01日 19:05:05 UTC) #4 
LGTM
Sign in to reply to this message.
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=73b9e4cb1afe *** exp/ssh: export type signal. Renamed to Signal R=dave, agl, rsc, ...
14 years, 1 month ago (2011年12月01日 19:06:34 UTC) #5 
*** Submitted as http://code.google.com/p/go/source/detail?r=73b9e4cb1afe ***
exp/ssh: export type signal. Renamed to Signal
R=dave, agl, rsc, golang-dev, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5450059
Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.
niemeyer
Taking me off CC list.
14 years, 1 month ago (2011年12月13日 21:29:17 UTC) #6 
Taking me off CC list.
Sign in to reply to this message.
|
Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b

AltStyle によって変換されたページ (->オリジナル) /