|
|
|
oauth: Add a public method to renew tokens.
Patch Set 1 #Patch Set 2 : diff -r 1d1bf184962b https://code.google.com/p/goauth2/ #Patch Set 3 : diff -r 1d1bf184962b https://code.google.com/p/goauth2/ #
Total comments: 4
Patch Set 4 : diff -r 1d1bf184962b https://code.google.com/p/goauth2/ #
Total comments: 1
Patch Set 5 : diff -r 1d1bf184962b https://code.google.com/p/goauth2/ #Total messages: 7
|
manugarg1
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2/
|
14 years, 1 month ago (2011年11月21日 11:10:38 UTC) #1 |
Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goauth2/
http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go File oauth/oauth.go (right): http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode187 oauth/oauth.go:187: // RenewToken renews the Token using Refresh Token. Let's just call this "Refresh" (like "Exchange"). // Refresh refreshes the Transport's AccessToken using its RefreshToken. http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode188 oauth/oauth.go:188: // If the Token cannot be renewed a non-nil os.Error is returned. drop this line, it's obvious http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode196 oauth/oauth.go:196: // Update the Token drop this comment, it's obvious http://codereview.appspot.com/5420051/diff/1003/oauth/oauth.go#newcode198 oauth/oauth.go:198: "grant_type": {"refresh_token"}, please run gofmt on this file
Hello adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
Looking good. Sorry, I'm picky about language. http://codereview.appspot.com/5420051/diff/7001/oauth/oauth.go File oauth/oauth.go (right): http://codereview.appspot.com/5420051/diff/7001/oauth/oauth.go#newcode187 oauth/oauth.go:187: // Refresh renews the Token using Refresh Token. Please use the language I provided: // Refresh renews the Transport's AccessToken using its RefreshToken.
Hello adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
*** Submitted as http://code.google.com/p/goauth2/source/detail?r=937479bfc9e1 *** oauth: Add a public method to renew tokens. R=adg CC=golang-dev http://codereview.appspot.com/5420051 Committer: Andrew Gerrand <adg@golang.org>