Issue 5369044: New baseline images for r2638

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(248)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5369044: New baseline images for r2638

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by epoger

Modified:
14 years, 2 months ago

Reviewers:
Steve VanDeBogart , vandebo (use chromium instead)

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

New baseline images for r2638 TBR=vandebo Committed: http://code.google.com/p/skia/source/detail?r=2639

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
M	gm/base-macmini/bitmapscroll_pdf.png	View	Binary file		0 comments	Download
M	gm/base-macmini/shadertext_pdf.png	View	Binary file		0 comments	Download

Total messages: 2

epoger

Steve- I'm going to go ahead and land this to greenify the buildbots. Please examine ...

14 years, 2 months ago (2011年11月09日 13:34:51 UTC) #1

Steve- I'm going to go ahead and land this to greenify the buildbots. Please
examine the image diffs and make sure they seem reasonable to you...

Steve VanDeBogart

Thanks for taking care of this. The diffs LGTM. On 2011年11月09日 13:34:51, epoger wrote: > ...

14 years, 2 months ago (2011年11月09日 16:40:41 UTC) #2

Thanks for taking care of this. The diffs LGTM.
On 2011年11月09日 13:34:51, epoger wrote:
> Steve- I'm going to go ahead and land this to greenify the buildbots. Please
> examine the image diffs and make sure they seem reasonable to you...