|
|
|
Created:
11 years, 11 months ago by jeff.allen Modified:
11 years ago Reviewers:
CC:
adg, golang-codereviews Visibility:
Public. |
go.blog: update the Thanksgiving doodle post
Fix the incorrect and missing image. Remove links that do not
format correctly. Update the code to match what is running now
on appspot.
Fixes issue 6908.
Patch Set 1 #Patch Set 2 : diff -r 1542e3ed4a52 https://code.google.com/p/go.blog #Patch Set 3 : diff -r 1542e3ed4a52 https://code.google.com/p/go.blog #
Total messages: 5
|
jeff.allen
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.blog
|
11 years, 11 months ago (2014年01月17日 11:35:41 UTC) #1 | |||||||||||||||||||||||
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.blog
It would be great to break out the code sections into Go source files, so they could be more easily tested (or at least verified as syntactically correct). This blog post was translated automatically from the HTML, that's why the code is in-line in the first place. Are you able to do that?
Sure, but it will be a few days, maybe more than a week. If you want this finished now, might be best to take this as it is, and then do the code-separation yourself.
No problem. Take your time. On 23 January 2014 01:23, <jeff.allen@gmail.com> wrote: > Sure, but it will be a few days, maybe more than a week. If you want > this finished now, might be best to take this as it is, and then do the > code-separation yourself. > > https://codereview.appspot.com/53670043/ >
R=close To the author of this CL: The Go project has moved to Gerrit Code Review. If this CL should be continued, please see the latest version of https://golang.org/doc/contribute.html for instructions on how to set up Git and the Go project's Gerrit codereview plugin, and then create a new change with your current code. If there has been discussion on this CL, please give a link to it (golang.org/cl/53670043 is best) in the description in your new CL. Thanks very much.
