Issue 5350046: Raise exception on HTTPException.

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(674)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5350046: Raise exception on HTTPException.

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by alainv

Modified:
14 years, 2 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Move the raise statement in AppEngineHttpConnection.getresponse. #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
M	httplib2/__init__.py	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3

jcgregorio_google

This change should also apply to the python 3 code.

14 years, 2 months ago (2011年11月08日 21:14:59 UTC) #1

This change should also apply to the python 3 code.

alainv

On 2011年11月08日 21:14:59, jcgregorio_google wrote: > This change should also apply to the python 3 ...

14 years, 2 months ago (2011年11月08日 22:06:53 UTC) #2

On 2011年11月08日 21:14:59, jcgregorio_google wrote:
> This change should also apply to the python 3 code.
I sent a patch here: http://codereview.appspot.com/5351048/
Same question for this copy: should it always raise an exception or only if
conn.getresponse() is None?

jcgregorio_google

LGTM On 2011年11月08日 22:06:53, alainv wrote: > On 2011年11月08日 21:14:59, jcgregorio_google wrote: > > This ...

14 years, 2 months ago (2011年11月09日 20:04:15 UTC) #3

LGTM
On 2011年11月08日 22:06:53, alainv wrote:
> On 2011年11月08日 21:14:59, jcgregorio_google wrote:
> > This change should also apply to the python 3 code.
> 
> I sent a patch here: http://codereview.appspot.com/5351048/
> 
> Same question for this copy: should it always raise an exception or only if
> conn.getresponse() is None?