Issue 5074: Adding typed test headers to Xcode project

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(112)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5074: Adding typed test headers to Xcode project

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 4 months ago by Preston

Modified:
11 years, 1 month ago

Reviewers:
wan

CC:
lodger , google c++ testing framework

Base URL:
http://googletest.googlecode.com/svn/trunk/xcode/

Visibility:
Public.

Patch Set 1 #

Created: 17 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
gtest.xcodeproj/project.pbxproj	View	8 chunks	+10 lines, -2 lines	1 comment	Download

Total messages: 2

Preston

Adding a couple of files to the Xcode project. The headers are: googletest/include/gtest/gtest-typed-test.h googletest/include/gtest/internal/gtest-type-util.h This ...

17 years, 4 months ago (2008年09月11日 20:33:48 UTC) #1

Adding a couple of files to the Xcode project. The headers are:
googletest/include/gtest/gtest-typed-test.h
googletest/include/gtest/internal/gtest-type-util.h
This fixes my build problems with the samples.

Zhanyong

Thanks for the quick fix, Preston! The strange thing is that the project file worked ...

17 years, 4 months ago (2008年09月12日 00:20:55 UTC) #2

Thanks for the quick fix, Preston!
The strange thing is that the project file worked fine for me with xcode 2.5 (I
tried both 'xcodebuild clean' + 'xcodebuild' and building in the Xcode IDE). A
closer look revealed that the tests aren't built - only the gtest library was. 
Do you know what might be wrong? Have you tried it with xcode 2.5? Thanks!
http://codereview.appspot.com/5074/diff/1/2
File gtest.xcodeproj/project.pbxproj (right):
http://codereview.appspot.com/5074/diff/1/2#newcode28
Line 28: 3BF6F2A00E79B5AD000F2EEE /* gtest-type-util.h in Copy Headers Internal
*/ = {isa = PBXBuildFile; fileRef = 3BF6F29F0E79B5AD000F2EEE /*
gtest-type-util.h */; };
Just curious: what is the word "Copy" supposed to mean here?