|
|
|
Created:
14 years, 4 months ago by Marius Modified:
14 years, 4 months ago Reviewers:
grund(helms-)mann CC:
avalonsailing_googlegroups.com Base URL:
http://avalonsailing.googlecode.com/svn/trunk/ Visibility:
Public. |
Patch Set 1 #
Total comments: 6
Total messages: 4
|
Marius
|
14 years, 4 months ago (2011年08月22日 10:36:31 UTC) #1 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
See my comments. otherwise fine. http://codereview.appspot.com/4937044/diff/1/modem/S61modem.sh File modem/S61modem.sh (right): http://codereview.appspot.com/4937044/diff/1/modem/S61modem.sh#newcode16 modem/S61modem.sh:16: $DIR/modemd --device=$DEVICE --phone=$PHONE --queue=$QUEUE | $DIR/plug -i /var/run/lbus >/dev/null 2>&1 & could you untabbify this? http://codereview.appspot.com/4937044/diff/1/modem/status.cc File modem/status.cc (right): http://codereview.appspot.com/4937044/diff/1/modem/status.cc#newcode55 modem/status.cc:55: // 1 = 1 inits: (0-9 A-Z a-z = 62 values, '{' = 63 jibes) jibes -> inits please comment that these are counts mod X http://codereview.appspot.com/4937044/diff/1/modem/statusd_main.cc File modem/statusd_main.cc (right): http://codereview.appspot.com/4937044/diff/1/modem/statusd_main.cc#newcode83 modem/statusd_main.cc:83: "\t --queue directory queue for messages (default %s)\n", tabs
Thanks for quick review. All done. Submitting now. http://codereview.appspot.com/4937044/diff/1/modem/S61modem.sh File modem/S61modem.sh (right): http://codereview.appspot.com/4937044/diff/1/modem/S61modem.sh#newcode16 modem/S61modem.sh:16: $DIR/modemd --device=$DEVICE --phone=$PHONE --queue=$QUEUE | $DIR/plug -i /var/run/lbus >/dev/null 2>&1 & On 2011年08月22日 10:57:00, grund(helms-)mann wrote: > could you untabbify this? Done. http://codereview.appspot.com/4937044/diff/1/modem/status.cc File modem/status.cc (right): http://codereview.appspot.com/4937044/diff/1/modem/status.cc#newcode55 modem/status.cc:55: // 1 = 1 inits: (0-9 A-Z a-z = 62 values, '{' = 63 jibes) On 2011年08月22日 10:57:00, grund(helms-)mann wrote: > jibes -> inits > > please comment that these are counts mod X Done. http://codereview.appspot.com/4937044/diff/1/modem/statusd_main.cc File modem/statusd_main.cc (right): http://codereview.appspot.com/4937044/diff/1/modem/statusd_main.cc#newcode83 modem/statusd_main.cc:83: "\t --queue directory queue for messages (default %s)\n", On 2011年08月22日 10:57:00, grund(helms-)mann wrote: > tabs Done.
LGTM On Mon, Aug 22, 2011 at 1:34 PM, <mariusv@google.com> wrote: > Thanks for quick review. All done. Submitting now. > > > > http://codereview.appspot.com/**4937044/diff/1/modem/S61modem.**sh<http://cod... > File modem/S61modem.sh (right): > > http://codereview.appspot.com/**4937044/diff/1/modem/S61modem.** > sh#newcode16<http://codereview.appspot.com/4937044/diff/1/modem/S61modem.sh#newcode16> > modem/S61modem.sh:16: $DIR/modemd --device=$DEVICE --phone=$PHONE > --queue=$QUEUE | $DIR/plug -i /var/run/lbus >/dev/null 2>&1 & > On 2011年08月22日 10:57:00, grund(helms-)mann wrote: > >> could you untabbify this? >> > > Done. > > > http://codereview.appspot.com/**4937044/diff/1/modem/status.cc<http://coderev... > File modem/status.cc (right): > > http://codereview.appspot.com/**4937044/diff/1/modem/status.**cc#newcode55<ht... > modem/status.cc:55: // 1 = 1 inits: (0-9 A-Z a-z = 62 values, '{' = > 63 jibes) > On 2011年08月22日 10:57:00, grund(helms-)mann wrote: > >> jibes -> inits >> > > please comment that these are counts mod X >> > > Done. > > > http://codereview.appspot.com/**4937044/diff/1/modem/statusd_**main.cc<http:/... > File modem/statusd_main.cc (right): > > http://codereview.appspot.com/**4937044/diff/1/modem/statusd_** > main.cc#newcode83<http://codereview.appspot.com/4937044/diff/1/modem/statusd_main.cc#newcode83> > modem/statusd_main.cc:83: "\t --queue directory queue for messages > (default %s)\n", > On 2011年08月22日 10:57:00, grund(helms-)mann wrote: > >> tabs >> > > Done. > > > http://codereview.appspot.com/**4937044/<http://codereview.appspot.com/4937044/> > -- This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks. Google Switzerland GmbH Identifikationsnummer: CH-020.4.028.116-1