Issue 4918047: Correct baud rates for AIS and compass as defaults

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(70)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4918047: Correct baud rates for AIS and compass as defaults

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by grund(helms-)mann

Modified:
11 years ago

Reviewers:
rekwall , bsuter

CC:
avalonsailing_googlegroups.com

Base URL:
http://avalonsailing.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	io/aiscat_main.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	io/compasscat_main.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2

grund(helms-)mann

14 years, 4 months ago (2011年08月23日 08:42:26 UTC) #1

rekwall

LGTM Den 23 augusti 2011 10:42 skrev <grundmann@google.com>: > Reviewers: bsuter, rekwall, > > > ...

14 years, 4 months ago (2011年08月23日 08:48:28 UTC) #2

LGTM
Den 23 augusti 2011 10:42 skrev <grundmann@google.com>:
> Reviewers: bsuter, rekwall,
>
>
>
> Please review this at
http://codereview.appspot.com/**4918047/<http://codereview.appspot.com/4918047/>
>
> Affected files:
> M io/aiscat_main.c
> M io/compasscat_main.c
>
>
> Index: io/compasscat_main.c
> ==============================**==============================**=======
> --- io/compasscat_main.c (revision 262)
> +++ io/compasscat_main.c (working copy)
> @@ -60,7 +60,7 @@
> fprintf(stderr,
> "usage: %s [options] /dev/ttyXX\n"
> "options:\n"
> - "\t-b baudrate (default unchanged)\n"
> + "\t-b baudrate (default 19200)\n"
> "\t-d debug (don't syslog, -dd is open serial as plain
> file)\n"
> , argv0);
> exit(2);
> @@ -127,7 +127,7 @@
> int main(int argc, char* argv[]) {
>
> int ch;
> - int baudrate = 0;
> + int baudrate = 19200; // 19200, 8, 1, N
>
> argv0 = strrchr(argv[0], '/');
> if (argv0) ++argv0; else argv0 = argv[0];
> Index: io/aiscat_main.c
> ==============================**==============================**=======
> --- io/aiscat_main.c (revision 262)
> +++ io/aiscat_main.c (working copy)
> @@ -53,7 +53,7 @@
> fprintf(stderr,
> "usage: %s [options] [/dev/ttyXX]\n"
> "options:\n"
> - "\t-b baudrate (default unchanged)\n"
> + "\t-b baudrate (default 38400)\n"
> "\t-d debug (don't syslog, -dd opens port as
> plain file)\n"
> "will read NMEA sentence from stdin with no arguments.\n"
> , argv0);
> @@ -102,7 +102,7 @@
> int main(int argc, char* argv[]) {
>
> int ch;
> - int baudrate = 0;
> + int baudrate = 38400;
>
> argv0 = strrchr(argv[0], '/');
> if (argv0) ++argv0; else argv0 = argv[0];
>
>
>