|
|
|
Created:
14 years, 5 months ago by rahulpaul Modified:
14 years, 5 months ago CC:
gdata-python-client-library-contributors_googlegroups.com, google-api-python-client_googlegroups.com Visibility:
Public. |
Patch Set 1 #
Total comments: 4
Patch Set 2 : Code review rework. #Total messages: 4
|
rahulpaul
|
14 years, 5 months ago (2011年08月16日 14:13:43 UTC) #1 |
http://codereview.appspot.com/4909045/diff/1/audit.py File audit.py (right): http://codereview.appspot.com/4909045/diff/1/audit.py#newcode20 audit.py:20: Command-line application that retrieves events through the Audit API. Add note that this works for enterprise and edu but not regular apps domains. http://codereview.appspot.com/4909045/diff/1/audit.py#newcode73 audit.py:73: def PrintFeed(activity_list): The results are in JSON and not Atom Feeds, so don't call it a feed, rename to print_activities. Note the lower case since this is open source and we follow PEP8.
Thanks for the review, Joe. Have addressed your comments. PTAL. http://codereview.appspot.com/4909045/diff/1/audit.py File audit.py (right): http://codereview.appspot.com/4909045/diff/1/audit.py#newcode20 audit.py:20: Command-line application that retrieves events through the Audit API. On 2011年08月16日 14:55:21, jcgregorio_google wrote: > Add note that this works for enterprise and edu but not regular apps domains. Done. I copied the text from the public docs - http://code.google.com/googleapps/domain/audit_admin/v1/getting_started.html#... http://codereview.appspot.com/4909045/diff/1/audit.py#newcode73 audit.py:73: def PrintFeed(activity_list): On 2011年08月16日 14:55:21, jcgregorio_google wrote: > The results are in JSON and not Atom Feeds, so don't call it a feed, rename to > print_activities. Note the lower case since this is open source and we follow > PEP8. Done.